Closed
Bug 368453
Opened 19 years ago
Closed 19 years ago
Implement __lookupGetter__ and __lookupSetter__ in Rhino
Categories
(Rhino Graveyard :: Core, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6R6
People
(Reporter: inonit, Assigned: norrisboyd)
Details
Attachments
(1 file)
|
5.66 KB,
patch
|
Details | Diff | Splinter Review |
Currently, __defineGetter__ and __defineSetter__ are working but the lookup-related methods are not implemented. This prevents various functional programming techniques, like "decorating" an existing method with a join point (like in aspect-oriented programming, for example).
|
Reporter | |
Updated•19 years ago
|
Severity: normal → enhancement
|
|
||
Comment 1•19 years ago
|
||
I'm investigating this. Started to code a fix.
|
|
||
Comment 2•19 years ago
|
||
Ran this against test suites with no new failures and fixed one test case (js1_5/GetSet/getset-006.js)
|
|
Assignee | |
Updated•19 years ago
|
Assignee: nobody → norrisboyd
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed:
Checking in NativeObject.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeObject.java,v <-- NativeObject.java
new revision: 1.44; previous revision: 1.43
done
Checking in ScriptableObject.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/ScriptableObject.java,v <-- ScriptableObject.java
new revision: 1.118; previous revision: 1.117
done
BTW, the test for this is js1_5/extensions/getset-006.js.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•19 years ago
|
||
Adding target milestone of 1.6R6 based on the date this bug was resolved FIXED.
Target Milestone: --- → 1.6R6
You need to log in
before you can comment on or make changes to this bug.
Description
•