Closed
Bug 368456
Opened 18 years ago
Closed 18 years ago
"Close Tab" in the context menu for tabs should not be disabled when only one tab is open
Categories
(Firefox :: Tabbed Browser, defect, P2)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha2
People
(Reporter: asaf, Assigned: asaf)
Details
(Keywords: regression)
Attachments
(1 file)
1.54 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Recent changes to the menu binding fixed the broken (for ages now) code in tabbrowser.xml which disables few menu items in the context menu for tabs when only one tab is open. We should revert this behavior for the "Close Tab" menu-item which became relevant for this case as well meanwhile.
Assignee | ||
Updated•18 years ago
|
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #253043 -
Flags: review?(gavin.sharp)
Comment 2•18 years ago
|
||
Comment on attachment 253043 [details] [diff] [review] patch By "recent changes to the menu binding" do you mean the fact that menuitem-base now inherits from general.xml's base bindings and thus has a disabled property?
Attachment #253043 -
Flags: review?(gavin.sharp) → review+
Comment 3•18 years ago
|
||
(due to the patch for bug 333023)
Assignee | ||
Comment 4•18 years ago
|
||
Right.
Assignee | ||
Comment 5•18 years ago
|
||
mozilla/toolkit/content/widgets/tabbrowser.xml 1.220
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•