368522 - Anti-phishing popup shouldn't have/should repurpose close button

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[Johnathan Nightingale [:johnath]]

Currently when visiting a blacklisted phishing site the user is presented with a deliberately-intrusive pop up decrying the site's content and inviting the user to run in the opposite direction.  This is, on balance, a good thing.  But this popup has a close button in the upper right (unsurprising, since conventional dialogs do) which, when clicked, dismisses the warning and restores the (blacklisted) site.  This is not the safest behaviour to have.  

There are actually more UI affordances (2) to ignore this warning than there are (1) to acknowledge it.

For the vast majority of scenarios, the anti-phishing dialog is not to be ignored, and the hyperlink text "Ignore this warning" does a good job of emphasizing the risk.  But the close button is much more benign looking, and might even be mistaken as indicating that the tab should be closed (it's even presented at approximately the same height as the tab bar).  I would propose that either:

a) The close button be removed.  
PRO: The close button is misleading for the reasons stated above.  This is not a "real" dialog, and needn't adhere to standard dialog conventions.
CON: It's sort of a dialog, and dialogs have close buttons.

b) The close button be remapped to do what "get me out of here" does.
PRO: Still safer behaviour
CON: Weird behaviour.  The one thing a close button DOESN'T do is take you somewhere else.  Putting this one out there for completeness, don't think it's the right option.

c) The close button be remapped to do what tab's close button would do (i.e. close the dialog and the phishing site)
PRO: Safer behaviour
CON: Breaks history for that tab, doesn't make much sense in a single-tab situation or more generally for users that don't use tabs.

My personal vote is for a), even given the risk of convention breakage.  The options outlined above further my belief that the close button is confusing/misleading.

Comment 1

[Johnathan Nightingale [:johnath]]

This bug references long-dead UI (and long may it remain so). RESO INVA