Closed Bug 36856 Opened 24 years ago Closed 24 years ago

Change "Browse" button name in linux installer

Categories

(SeaMonkey :: Installer, defect, P3)

Product:
SeaMonkey
Component:
Installer
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jmd, Assigned: samir_bugzilla)

Details

There are quite a few issues I'm having with the installer. I'm going to file
them all in this one bug report, because I have a feeling they are known, even
though I read all open installer bugs and they weren't listed.

I've experianced all of these with both todays (2000-04-22) and a few days ago's
build.

1 - trivial - The button named 'Browse' in the destination box would be more
intuitivly named 'Change', as you dont nessicarily have to browse through the
directory structure, it's just an option the GTK file selection dialog gives
you. You could simply type in /foo/bar if you'd like.

2 - minor - directory creation doesn't seem to honor umask

3 - normal - after downloading part of install is complete, the aligning of the
text, and the percentage bars all of a sudden think the window they are in is
alot larger. You have to enlarge the box to about triple its original size to
fit them in.

4 - normal - when doing a custom install, clicking anywhere on the component
names X/un-X's them... Unlike win32, where you can click on the name, and read
the decription. This is unexpected, and quite possibly not noticed by the user
(i caught it out of the corner of my eye).

5 - critical - unpacking part of install rarely completes. I've had segmentation
faults, and most often, somewhere between 50 and 99% through, it becomes
unresponsive and needs to be killed. This usually happens on "file N-1 of N",
two files away from completing. Here is an error I got once (out of four
lockups):

Gtk-CRITICAL **: file gtkprogress.c: line 518 (gtk_progress_set_percentage):
assertion `percentage >= 0 && percentage <= 1.0' failed.

(-1% done, woo!)

I think thats it...for now.
reassigning to sgehani
Assignee: ssu → sgehani
1: Will consult docs about wording.  
2: Will investigate.
3: Known issue.  Will fix to truncate xpinstall status callback strings to leaf.
4: This is default GTK widget behavior.  Taking patches :o)
5: Possibly serious.  Will investigate.  
(The assertion will go away when addressing item 3.)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → M16
Still investigating item 5.  Item 3 has been resolved.
Status: NEW → ASSIGNED
issue #5 sounds serious, need to investigate and fix by PR2
Keywords: nsbeta2
Target Milestone: M16 → M17
Item 3 has been fixed.
Issue #1 will be addressed by this bug.  Changing summary accordingly.
Issue #2 will be addressed by bug 38755.
Issue #3 was fixed by bug 38035.
Issue #4 will not be addressed.
Issue #5 is addressed by bug 36781.  Syd is on it.

PDT,
Hope this helps.

Vera,
Can you recommend or verify the change for issue #1?  Then reassign this 
back to me.  Thanks.
Assignee: sgehani → verah
Status: ASSIGNED → NEW
Summary: various issues with linux installer → Change "Browse" button name in linux installer
I'll check on this (gotta look at it on a Linux box) and get back to you soon.
Status: NEW → ASSIGNED
"Change" looks good to me! Go for it.
Assignee: verah → sgehani
Status: ASSIGNED → NEW
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I notice today that this is a cross platform issue, I assume the patch fixes it 
cross platform? (I'll check todays builds when they pop up...)

Also, might 'Choose' be a better label then 'Change'?


Jeremy,
To answer your first question: no, this code is not cross-platform.  It is 
*very* platform specific since the installer stubs are lightweight and hence 
cannot link into to our rendering engine code and cannot take advantage of our 
xptoolkit, unfortunately.

I happen to also be responsible for the Mac installer where the verbage is 
"Select folder..." which is common and expected by Mac users and do not 
plan to change that.  Hence, there's no need to look that over.  Thanks though.

Also, I think 'Change' is fine for now because 'Choose' would be more 
appropriate if a default wasn't supplied.  Given the default, we only want users 
to 'Change' if they disagree with the default location.  Acceptable 
justification?

We appreciate the time you are taking to look at these issues.
Agree 'change' is more appropriate since a default it provided.

I checked on InstallShield, the most popular installer software for win32, and 
it uses the misnomer 'Browse' next to the destination, so win32 is good to go I 
suppose. 

Agree platform verbage should be kept.

This makes mac/win32/linux installer good, and I don't think solaris/irix has 
one (yet?).

Agree RESOLVED FIXED.
We aren't building solaris/irix cause we need to port.  Know anyone interested 
in taking on the porting work?  :o)
verified- build 2000051108M16
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.