368626 - Importer (Win Eudora, Address Book). Mailing list nickname not assigned to 'nickname' in Penelope

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Matt Dudziak]

The problem is that when you import a group nickname from Eudora, the Eudora nickname is assigned to the Penelope 'List Name' and not the 'List Nickname'. Should probably be assigned to both.

To reproduce:

- In Eudora, create a nickname with 2 or more addresses
- Import Address Book into Penelope 
- Note imported nickname has the Eudora 'nickname' mapped to 'List Name' and that the Penelope 'List Nickname' is blank

Comment 1

[Geoffrey C. Wenger]

Attachment: Patch that fixes bug. Note patch was not created with CVS.

Actually it wasn't previously importing mailing list name quite correctly either - it was just using the mailing list nickname as the name. Now imports the name (if any) as the mailing list name (if none, defaults back to using nickname as name) and imports the nickname as the mailing list nickname.

Comment 2

[David :Bienvenu]

Comment on attachment 262174 [details] [diff] [review]
 Patch that fixes bug. Note patch was not created with CVS.

I changed this:

+  if ( !name.IsEmpty() )
+    rv = pDb->AddListName(newRow, name.get());
+  else
+    rv = pDb->AddListName(newRow, pEntry->m_name.get());

into:

  rv = pDb->AddListName(newRow, name.IsEmpty() ? pEntry->m_name.get() : name.get());

Comment 3

[David :Bienvenu]

Attachment: fix checked in.

Comment 4

[Geoffrey C. Wenger]

Thanks much for the improvement and for submitting to trunk.