368711 - (vc9-runtime) Need method for copying runtime DLLs when building with VC9/"Orcas"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gábor Stefanik]

Currently, we avoid errors related to the lack of the Microsoft Visual C/C++ 8 runtimes by installing the runtime DLLs (msvcr80.dll and msvcp80.dll) automatically if they are missing. However, Visual C/C++ 9 (codename "Orcas") uses two new DLLs, called msvcr90.dll and msvcp90.dll, that are not picked up by the build script. We can solve this problem in 2 ways: 
1. (the quick-and-easy way) Add msvcr90.dll and msvcp90.dll to the Win32 build's makefile.in file. (But we will have to do this with the new DLLs each time Microsoft releases a new version of the runtimes.)
2. (the preferred way) Since the DLL files have standard names (with the syntax "msvc"+<runtime type ("p" or "r")>+<runtime major+minor version>.dll), we can probably make a script that automatically copies the correct runtime DLLs, recognized by name.

Also, we have to work out the behaviour of the runtime copying script when the runtime files are present on the system, but of a different revision than the ones to be copied (e.g. VC8 RTM vs. VC8 SP1), so that it recognizes which version is newer. It is not desirable that versions built with VC8 SP1 don't install correctly on systems that have VC8 RTM runtimes. Probably we should also check the version of the DLLs, not just the name.

Comment 1

[Benjamin Smedberg]

Well, we copy whatever version of the DLLs is in WIN32_REDIST_DIR. I don't think we want complicated checks. I think that for the time being we should just switch msvcr80 or msvcr90 based on _MSC_VER.

Comment 2

[Gábor Stefanik]

From build/win32/makefile.in:

>ifdef WIN32_REDIST_DIR
>
>ifeq (1400,$(_MSC_VER))
>REDIST_FILES = \
>	Microsoft.VC80.CRT.manifest \
>	msvcm80.dll \
>	msvcp80.dll \
>	msvcr80.dll \
>	$(NULL)
>endif

From this, it seems that this only works if we are using VS2005. We shouldn't hardcode the _MSC_VER to check against, and neither should we hardcode the DLL names. Maybe we want to generate the DLL names according to the version.

Comment 3

[Benjamin Smedberg]

> From this, it seems that this only works if we are using VS2005. We shouldn't
> hardcode the _MSC_VER to check against, and neither should we hardcode the DLL

Why not? We don't need an infinitely flexible system, nor generated filenames. Just put another block in there for VC9 and be done with it!

Comment 4

[Gábor Stefanik]

OK, I'm making a patch for that. Is it OK to add my name after "Contributors"? (Currently there is nothing after that. Is this due to the current version being the "Initial Code"?)

Comment 5

[Benjamin Smedberg]

Yes, that's fine. That is probably the reason, plus people don't update contributors religiously.

Comment 6

[Gábor Stefanik]

Attachment: Make runtime DLL copying work in VC9 builds

This patch makes sure that the runtime files are copied when building with VC9. _MSC_VER is checked against "1500" because cl.exe is now version 15 (it was 14 in VC8)

Comment 7

[Gábor Stefanik]

Comment on attachment 253366 [details] [diff] [review]
Make runtime DLL copying work in VC9 builds

Oops. CVS didn't recognize the Unicode caracter in my name. New patch coming.

Comment 8

[Gábor Stefanik]

Attachment: Second try. Don't mess up unicode characters this time.

The same patch, converted to UTF8 so that there is no Unicode error.

Comment 9

[Gábor Stefanik]

Comment on attachment 253368 [details] [diff] [review]
Second try. Don't mess up unicode characters this time.

Will someone review this patch? It has been a week since the last change on this bug!

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 253368 [details] [diff] [review]
Second try. Don't mess up unicode characters this time.

See http://benjamin.smedbergs.us/blog/2007-02-05/micah-wilkes-smedberg/ . You might want to switch the review request to Ted Mielczarek (ted.mielczarek).

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 253368 [details] [diff] [review]
Second try. Don't mess up unicode characters this time.

Building with VC9?  Has the world gone crazy?
r=me

Comment 12

[Gábor Stefanik]

Could someone check in this patch on the trunk? I think this should be in there.

Comment 13

[Nickolay_Ponomarev]

Checked in:
mozilla/build/win32/Makefile.in  1.6

Comment 14

[Gábor Stefanik]

Just tested and we are still not really there yet. DLLs are copied to dist/bin, but not to dist/firefox and the final installer. Patch coming in the new post.

Comment 15

[Gábor Stefanik]

Attachment: Make DLL copying work in VC9. This time really.

The patch.

Comment 16

[Gábor Stefanik]

Could this be checked in? I assume so, from the r+ flag.

Comment 17

[Nickolay_Ponomarev]

mozilla/xpinstall/packager/packages-win  1.315