368721 - issues with template using simple rule

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

The testcase at the url doesn't display anything, yet it should display the text: 'Barn Owl'.

Comment 1

[Neil Deakin]

Attachment: fix some issues

The attached patch fixes some issues with this test:
 - regression which prevents conditional filter attributes on a <template> element from being parsed.
 - the 'xmlns:xxx' attributes should be skipped
 - also fixes a warning with an uninitialized value

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Without the patch the testcase displays Emu, Barn Owl, Raven, so the
filter doesn't seem to work at all.
With the patch only Barn Owl is shown.

This is a regression from what?

Comment 3

[Neil Deakin]

Point one in comment 1 is a regression from bug 285631 because the new template builder doesn't parse the attributes so the output appears unfiltered. Point 2 isn't a regression and makes the filter work properly. Both are actually separate bugs but I have combined them as they both affect the same file and testcase.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 253364 [details] [diff] [review]
fix some issues

> nsXULTemplateQueryProcessorRDF::Propagate(nsIRDFResource* aSource,
>                                           nsIRDFResource* aProperty,
>                                           nsIRDFNode* aTarget)
> {
>     // When a new assertion is added to the graph, determine any new matches
>     // that must be added to the template builder. First, iterate through all
>     // the RDF tests (<member> and <triple> tests), and find the topmost test
>     // that would be affected by the new assertion.
>-    nsresult rv;
>+    nsresult rv = NS_OK;

Change the ending |return rv| to |return NS_OK| instead.

Comment 5

[Neil Deakin]

There's a test for this as part of the xul tests in bug 368097.