Closed
Bug 368740
Opened 17 years ago
Closed 17 years ago
Crash [@ nsIFrame::IsThemed] when trying to get the computed style of a button in iframe
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha8
People
(Reporter: martijn.martijn, Assigned: dbaron)
References
Details
(Keywords: crash, regression, testcase, Whiteboard: [patch])
Crash Data
Attachments
(2 files)
723 bytes,
text/html
|
Details | |
601 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
See testcase, which crashes current trunk build of Mozilla on load for me. I'm on windowsxp, using the classic theme. This regressed between 2007-01-28 and 2007-01-29, I think a regression from bug 366722. Talkback ID: TB28864236W nsIFrame::IsThemed [mozilla\dist\include\layout\nsiframe.h, line 785] nsComputedDOMStyle::GetBorderLeftWidth [mozilla\layout\style\nscomputeddomstyle.cpp, line 1180] nsComputedDOMStyle::GetPropertyValue [mozilla\layout\style\nscomputeddomstyle.cpp, line 283] NS_InvokeByIndex [mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, line 102] XPCWrappedNative::CallMethod [mozilla\js\src\xpconnect\src\xpcwrappednative.cpp, line 2209]
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #253407 -
Flags: superreview?(roc)
Attachment #253407 -
Flags: review?(roc)
Assignee | ||
Updated•17 years ago
|
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9beta
Attachment #253407 -
Flags: superreview?(roc)
Attachment #253407 -
Flags: superreview+
Attachment #253407 -
Flags: review?(roc)
Attachment #253407 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•17 years ago
|
||
Verified fixed, using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070131 Minefield/3.0a2pre
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 4•17 years ago
|
||
A test for this should probably test enumerating all members of computed style on: * a visible element * an element that is display:none * an element that is a descendant of something that is display:none Are there instructions for writing/running mochitest tests somewhere?
Comment 5•17 years ago
|
||
There's <http://lxr.mozilla.org/mozilla/source/testing/mochitest/README.txt>, at least. There should be more, but I think at the moment that document's it.
Updated•13 years ago
|
Crash Signature: [@ nsIFrame::IsThemed]
Comment 7•11 years ago
|
||
Crash test: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fffe9eb4f8c
Flags: in-testsuite? → in-testsuite+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1fffe9eb4f8c
You need to log in
before you can comment on or make changes to this bug.
Description
•