If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[PS] Partially transparent images should blend to white

RESOLVED FIXED

Status

()

Core
Printing: Output
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: tor, Assigned: tor)

Tracking

({verified1.8.1.4})

1.8 Branch
x86
Linux
verified1.8.1.4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

2.98 KB, patch
Kenneth Herron
: review+
Stuart Parmenter
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Created attachment 253409 [details] [diff] [review]
preblend to white in nsPostScriptObj::draw_image

nsImageGtk::LockImagePixels turns transparent portions of the image white for 1-bit alpha images, so that printing doesn't show a black background.  While we shouldn't destructively change the image data for 8-bit alpha images, printing needs to blend the image with white to avoid the black background for these images as well.

This affects all 8-bit alpha images and SVG printing.  Test URL is the former, for the latter try this page:  http://www.w3.org/TR/SVG11/images/shapes/rect01.svg .
(Assignee)

Updated

11 years ago
Attachment #253409 - Flags: review?(kherron+mozilla)
(Assignee)

Comment 1

11 years ago
Created attachment 253411 [details] [diff] [review]
tidy patch
Attachment #253409 - Attachment is obsolete: true
Attachment #253411 - Flags: review?(kherron+mozilla)
Attachment #253409 - Flags: review?(kherron+mozilla)

Updated

11 years ago
Attachment #253411 - Flags: review?(kherron+mozilla) → review+
(Assignee)

Updated

11 years ago
Attachment #253411 - Flags: superreview?(pavlov)

Comment 2

11 years ago
do we care about this code?  none of it is built on the trunk anymore...
(Assignee)

Comment 3

11 years ago
This is a patch intended for the branch only.

Updated

11 years ago
Attachment #253411 - Flags: superreview?(pavlov) → superreview+
(Assignee)

Comment 4

11 years ago
Comment on attachment 253411 [details] [diff] [review]
tidy patch

Fixes printing of SVG and 8-bit alpha images on linux to not use black backgrounds.
Attachment #253411 - Flags: approval1.8.1.4?
Comment on attachment 253411 [details] [diff] [review]
tidy patch

approved for 1.8.1.4, a=dveditz for release-drivers
Attachment #253411 - Flags: approval1.8.1.4? → approval1.8.1.4+
(Assignee)

Comment 6

11 years ago
Checked in on MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.4
Resolution: --- → FIXED
verified fixed 1.8.1.4 using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4pre) Gecko/2007042803 BonEcho/2.0.0.4pre - Fedora FC 6 and the test link from comment #0. The result is now the expected result - the background is white, not black anymore. -> adding verified keyword
Keywords: fixed1.8.1.4 → verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.