368836 - improve support for initial in SVG

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Robert Longson [:longsonr]]

Attachment: patch

Make support for 'initial' less spotty, at least within SVG. 
Implementation based on that done for color-interpolation/color-interpolation-filers.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 253486 [details] [diff] [review]
patch

There are a bunch of places where you have two spaces after an "==".  If you fix those to just have one space, r+sr=dbaron.  Sorry for the delay here.

I'd also note that the reordering in nsStyleSVGReset's computation method changes things away from matching the order of the member variables.  Maybe it should stay as-is?  (I'm assuming it's just reordering, I didn't actually check.  If it's not, please let me know.)

Comment 2

[Robert Longson [:longsonr]]

Attachment: version for check in

Comment 3

[Robert Longson [:longsonr]]

(In reply to comment #1)
> (From update of attachment 253486 [details] [diff] [review])
> There are a bunch of places where you have two spaces after an "==".  If you
> fix those to just have one space, r+sr=dbaron.  Sorry for the delay here.
> 

Done.

> I'd also note that the reordering in nsStyleSVGReset's computation method
> changes things away from matching the order of the member variables.  Maybe it
> should stay as-is?  (I'm assuming it's just reordering, I didn't actually
> check.  If it's not, please let me know.)
> 

I've reverted those changes so ordering is unchanged. The ordering in ComputeSVGResetData is similar but not quite the same as the order of the member variables. The ordering in ComputeSVGData is alphabetical and I was trying to match that. If reordering is desirable it can be done in a different patch.

Comment 4

[Robert Longson [:longsonr]]

attachment (id=260989) [details]

checked in.