368867 - spell check results from previous message show up (cached compose window related?)

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[(not reading, please use [e-mail] instead)]

spell check results from previous message show up (cached compose window related?)

I'm using version 2 beta 2 (20070131), so I think this is a recent regression (caused by the spell checking of the subject area?)

steps to reproduce:

1) launch tbird
2) compose a new message, in the body type "mitai foo"
3) right click on mitai, get the list of suggestions
4) close the window, don't save as draft
5) compose a new message, type "mitai foo"

right click on mitai, you'll get double the suggestions
right click on foo, you'll get the mitai suggestions on top of the foo suggestions.

Comment 1

[Scott MacGregor]

I can easily reproduce this. May be fall out from converting to InlineSpellCheckUI. It does seem to be related to the compose window.

Comment 2

[Scott MacGregor]

I think we just need to call InlineSpellCheckerUI.uninit in MsgCompose.js when closing a compose window (even when it is being recycled). Just gotta find the correct spot to do this.

Comment 3

[Scott MacGregor]

Attachment: the fix

In the OnClose method for a recycled compose window, call InlineSpellCheckerUI.clearSuggestionsFromMenu to clear any misspelling suggestions that are in the editor context menu.

Comment 4

[Scott MacGregor]

cc'ing Neil, I suspect he'll want to do something similar for seamonkey's MsgComposeCommands.js

Comment 5

[[e-mail]]

Thanks, the only difference was that I didn't check in any ^M characters ;-)

Comment 6

[Scott MacGregor]

bleh, sometimes the cross commit tool does that to me. I fixed the ^M characters. Thanks for noticing that.

Comment 7

[Tracy Walker [:tracy]]

verified with 2.0.0.0 rc2 on Windows XP