368914 - remove unnecessary strings in contentAreaCommands.dtd

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Žiga Sancin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: 

There are some strings in contentAreaCommands.dtd that can be removed now that bug 333607 has been fixed. Patch coming in a minute...

Reproducible: Always

Comment 1

[Žiga Sancin]

Attachment: remove unnecessary strings

The remaining strings depend on mailWindowOverlay.xul. We might consider moving them to messenger.dtd, and then cvs removing contentAreaCommands.dtd and deleting the references in hiddenWindow.xul and mailWindowOverlay.xul.

Comment 2

[Scott MacGregor]

Comment on attachment 253557 [details] [diff] [review]
remove unnecessary strings

Let's keep this trunk only for now. I like your suggestion of possibly removing this file altogether.

Comment 3

[Žiga Sancin]

Attachment: remove contentAreaCommands.dtd

I've moved the "Content Pane Context Menu" strings below the "Message Header Context Menu" section in messenger.dtd and removed the references in mailWindowOverlay.xul and hiddenWindow.xul. There's nothing unusual happening in my local trunk build.

Comment 4

[Scott MacGregor]

Comment on attachment 253687 [details] [diff] [review]
remove contentAreaCommands.dtd

nice!

Comment 5

[Worcester12345]

"footprint" keyword?

Comment 6

[Phil Ringnalda (:philor)]

Scott, just to make sure, this is ready to land (with a cvs rm contentAreaCommands.dtd) once someone notices it waiting, right?

Ziga, thanks for doing this! I was just about to start doing it myself, when for once I looked for a bug first. You might want to be a little less patient about waiting for someone to land your patch, though ;)

Comment 7

[Žiga Sancin]

Scott probably forgot about this bug because of the Thunderbird 2 freeze madness (this patch missed the string freeze for a few weeks).

I saw your toolkit string-killing spree, so I was hoping that you'll come across this bug. Thanks for making me an assignee, I don't have the privileges to do it myself. I'm going to be less patient in the future. Scott beware! :D

Comment 8

[Scott MacGregor]

yeah this is ready to land on the trunk. Thanks guys!

bisi, be less patient, I'll beware :)

Comment 9

[Axel Hecht [:Pike]]

Ziga, I adjusted your bugzilla privs so that you can assign bugs to yourself now. And a bunch of other stuff, beware the powers ;-)

Comment 10

[Phil Ringnalda (:philor)]

mail/base/content/hiddenWindow.xul: 1.10
mail/base/content/mailWindowOverlay.xul: 1.202
mail/locales/jar.mn: 1.48
mail/locales/en-US/chrome/communicator/contentAreaCommands.dtd: delete
mail/locales/en-US/chrome/messenger/messenger.dtd: 1.62

Comment 11

[Žiga Sancin]

More privileges, more responsibility. ;)

Thanks for the checkin Phil!