Closed
Bug 368918
Opened 18 years ago
Closed 17 years ago
browser.xul should use editMenuOverlay rather than duplicating its code
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha3
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.59 KB,
patch
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #253558 -
Flags: review?(gavin.sharp)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 253558 [details] [diff] [review] patch Do you think it's worth filing a bug to remove goUpdateSelectEditMenuItems, since it's now apparently unused? (TB seems to have it's own version, though I haven't verified that it only uses that one).
Attachment #253558 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
mail/ doesn't seem to use editMenuOverlay.* at all so we can just remove goUpdateSelectEditMenuItems.
Whiteboard: [a3]
Target Milestone: Firefox 3 alpha2 → Firefox 3
|
|
Assignee | |
Comment 4•17 years ago
|
||
mozilla/toolkit/content/editMenuOverlay.js 1.2 mozilla/toolkit/content/editMenuOverlay.xul 1.5 mozilla/toolkit/content/jar.mn 1.29 mozilla/browser/base/content/browser-sets.inc 1.93 mozilla/browser/base/content/macBrowserOverlay.xul 1.14 mozilla/browser/base/content/utilityOverlay.js 1.48
Attachment #253558 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [a3]
Target Milestone: Firefox 3 → Firefox 3 alpha3
|
||
Comment 5•13 years ago
|
||
(In reply to comment #4) http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2007-02-14+13%3A28&maxdate=2007-02-14+13%3A28
You need to log in
before you can comment on or make changes to this bug.
Description
•