368929 - only launch helper.exe (formerly known as uninst.exe) with /postupdate for firefox, until mail and calendar support it

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

only launch helper.exe (formerly known as uninst.exe) with the "/postupdate" argument for firefox, until mail and calendar support it.

this is a spin off from bug #354226

I want a new bug so that we don't forget to land this supplemental fix, and to let scott and lilmatt know about it.

note, firefox's helper.exe has support for /postupdate, and at some point, we'll need to add support for that (and /fixreg) to the uninstaller.nsi for mail and calendar.

this is part of the massive Vista landing by rstrong:

Landing of interdependent bugs for Vista support. Bug 354005 Setting the app as the OS default is broken on Vista. r=sspitzer, r=dougt, sr=bsmedberg. Bug 351949 – Automatic Update is not working for Vista users with limited account privilege and UAC (User Account Control) enabled. r=sspitzer, r=rstrong. Bug 354226 – nsPostUpdateWin.js fails to update registry keys / log files after an update has been applied. r=rstrong. 

see http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/installer/windows/nsis&command=DIFF_FRAMESET&file=uninstaller.nsi&rev1=1.3&rev2=1.4&root=/cvsroot for robert's changes.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: the patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 253569 [details] [diff] [review]
the patch

this already has r=rstrong.

we want this on the MOZILLA_1_8_BRANCH, so seeking approval, so it doesn't get lost.

note, we want to land this with robert's upcoming massive landing for vista support on the MOZILLA_1_8_BRANCH.

Comment 3

[(not reading, please use [e-mail] instead)]

fixed on the trunk:

Checking in nsUpdateService.js.in;
/cvsroot/mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in,v  <--  nsUpda
teService.js.in
new revision: 1.128; previous revision: 1.127
done

Comment 4

[(not reading, please use [e-mail] instead)]

note to lilmatt and mscott:

on the trunk, only firefox is doing what nsPostUpdateWin.js used to do for us
(because that code is now in helper.exe.)

this includes some registry cleanup (and log file cleanup) after a sofware
update. 

Comment 5

[Robert Strong (they/them - no direct email)]

this will make it so a new branch patch has to be created without it for bug 354226

Comment 6

[(not reading, please use [e-mail] instead)]

rob's right, this is part of the last patch in bug #354226.  So getting of the MOZILLA_1_8_BRANCH radar.

to summarize for mscott / lilmatt:  once mail's/calendar's uninstaller.nsi has support for /postudpate and /fixreg, we'll want to back this change out.