368965 - patch for bugzilla-submit to allow setting of e.g groups "bit-fields"

Status: UNCONFIRMED

(Bugzilla :: Bug Import/Export & Moving, enhancement)

Description

[josef radinger]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.9) Gecko/20061219 Fedora/1.5.0.9-1.fc6 Firefox/1.5.0.9 pango-text
Build Identifier: 2.22

it should be possible to set bugzilla's group-bits when processing bugs via bugzilla-submit.

Reproducible: Always

Comment 1

[josef radinger]

fixed with the given patch. 
i tested it and it works great.

Comment 2

[josef radinger]

Attachment: allows setting ob bit-fields

now one can set bit-fields by using:

bit-12: checked
bit-14: checked
bit-16: checked

Comment 3

[josef radinger]

I sent the original patch (not working) to christian robottom reis, who was kind enough to fix my patch and requesting that i file a bug here.

On Wed, Jan 24, 2007 at 02:52:35PM +0100, Josef Radinger wrote:
> works great
> :)
> 
> thanks for work

Could you file a bug on bugzilla.mozilla.org and add this patch to it?
That way it can get rolled back into the main release.

Thanks,
-- 
Christian Robottom Reis | http://async.com.br/~kiko/ | [+55 16] 3376 0125

Comment 4

[josef radinger]

Attachment: new patch. the first one was wrong. sorry

The first patch was not the correct one. sorry.

Comment 5

[Kevin Benton]

Comment on attachment 253603 [details] [diff] [review]
allows setting ob bit-fields

Based on comments, marking as obsolete.

Comment 6

[Kevin Benton]

Comment on attachment 258768 [details] [diff] [review]
new patch. the first one was wrong. sorry

Hey Josef,

When submitting a patch for a file in the contrib directory, please make sure you do your diff from the Bugzilla root directory rather than from the contrib/bugzilla-submit dir.  This helps us when trying to figure out where your file is among the hundreds we have to maintain.

I would review this further for you, but I am not a Python expert.  FYI - one reason why this code is in contrib (among many others) is that it's in Python and not Perl as the rest of the Bugzilla code is Perl-based.

One more note - if you submit a patch that replaces an older patch, it's always good to mark the old patch as obsolete - that way we know not to even bother looking at the old patch.

Thanks for your contributions.