split client name and version number into separate query params

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
--
enhancement
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: Tony Chang (Google), Assigned: Tony Chang (Google))

Tracking

({verified1.8.1.4})

Trunk
verified1.8.1.4
Points:
---
Bug Flags:
blocking1.8.1.4 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
For logging reasons, it's easier if we have the client name and the app version in separate query parameters when making update and lookup requests.
(Assignee)

Comment 1

11 years ago
Created attachment 253676 [details] [diff] [review]
split {moz:client} and {moz:version}

Specifically, this changes the update url to be
update?client=Firefox&appver=2.0.0.1&
or
update?client=navclient-auto-ffox&appver=2.0.0.1&

And it changes the lookup url to be 
lookup?client=Firefox&appver=2.0.0.1&
or
lookup?client=navclient-auto-ffox&appver=2.0.0.1&
Attachment #253676 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #253676 - Flags: review? → review?(marria)

Comment 2

11 years ago
Comment on attachment 253676 [details] [diff] [review]
split {moz:client} and {moz:version}

Looks good to me
Attachment #253676 - Flags: review?(marria) → review+
(Assignee)

Comment 3

11 years ago
On trunk.

Checking in app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.169; previous revision: 1.168
done
Checking in components/safebrowsing/content/globalstore.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/globalstore.js,v  <--  globalstore.js
new revision: 1.15; previous revision: 1.14
done
(Assignee)

Updated

11 years ago
Flags: blocking1.8.1.3?
(Assignee)

Updated

11 years ago
Attachment #253676 - Flags: approval1.8.1.3?
Blocking to keep on the radar for now.

How is the trunk version working? Happy with the patch? Does the server back-end handle getting two different formats (new and old) at the same time?
Flags: blocking1.8.1.4? → blocking1.8.1.4+
(Assignee)

Comment 5

11 years ago
(In reply to comment #4)
> How is the trunk version working? Happy with the patch? Does the server
> back-end handle getting two different formats (new and old) at the same time?

The server handles both (new and old) formats.  It's working fine on trunk right now.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 253676 [details] [diff] [review]
split {moz:client} and {moz:version}

approved for 1.8.1.4, a=dveditz for release-drivers
Attachment #253676 - Flags: approval1.8.1.4? → approval1.8.1.4+
(Assignee)

Comment 7

11 years ago
on branch

Checking in app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.71.2.82; previous revision: 1.71.2.81
done
Checking in components/safebrowsing/content/globalstore.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/globalstore.js,v  <--  globalstore.js
new revision: 1.1.2.11; previous revision: 1.1.2.10
done
Keywords: fixed1.8.1.4

Comment 8

11 years ago
Verified on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4pre) Gecko/20070506 BonEcho/2.0.0.4pre

Used livehttpheaders and searched for update and lookup urls which now look like:

http://sb.google.com/safebrowsing/update?client=navclient-auto-ffox&appver=2.0.0.4pre...

http://sb.google.com/safebrowsing/lookup?sourceid=firefox-antiphish&features=TrustRank&client=navclient-auto-ffox&appver=2.0.0.4pre...

Updated

11 years ago
Keywords: fixed1.8.1.4 → verified1.8.1.4
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.