369014 - Timezone string not exported in ics

Status: VERIFIED FIXED

(Calendar :: Import and Export, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Importing an calendar with timezone string and exporting it results in loosing information, especially the timezone string. See http://litmus.mozilla.org/show_test.cgi?id=2943

Input calendar:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
BEGIN:VTIMEZONE
TZID:/mozilla.org/20050126_1/America/Argentina/ComodRivadavia
X-LIC-LOCATION:America/Argentina/ComodRivadavia
BEGIN:STANDARD
TZOFFSETFROM:-0300
TZOFFSETTO:-0300
TZNAME:ART
DTSTART:19700101T000000
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
CREATED:20070201T161705Z
LAST-MODIFIED:20070201T161705Z
DTSTAMP:20070201T161705Z
UID:9d7b433e-b20f-11db-ae39-001451206316
SUMMARY:Argentina Como Riveria feb 12 at 1pm
DTSTART;TZID=/mozilla.org/20050126_1/America/Argentina/ComodRivadavia:
 20070212T130000
DTEND;TZID=/mozilla.org/20050126_1/America/Argentina/ComodRivadavia:
 20070212T140000
END:VEVENT
END:VCALENDAR

Output calendar:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
BEGIN:VEVENT
CREATED:20070201T213642Z
LAST-MODIFIED:20070201T213642Z
DTSTAMP:20070201T213642Z
UID:9d7b433e-b20f-11db-ae39-001451206316
SUMMARY:Argentina Como Riveria feb 12 at 1pm
DTSTART:20070212T160000
DTEND:20070212T170000
END:VEVENT
END:VCALENDAR

Comment 1

[Matthew (lilmatt) Willis]

Attachment: Fixes "Argentica" typo

This is caused by a typo in the special case conversion code.
("Argentica" instead of "Argentina")

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 253675 [details] [diff] [review]
Fixes "Argentica" typo

r=dmose

Comment 3

[Matthew (lilmatt) Willis]

Patch checked in on:
  SUNBIRD_0_3_BRANCH
  LIGHTNING_0_3_BRANCH
  MOZILLA_1_8_BRANCH
  trunk

-> FIXED

Comment 4

[Martin Schröder [:mschroeder]]

Comment on attachment 253675 [details] [diff] [review]
Fixes "Argentica" typo

Removing first‑review?. Patch was already checked in.

Comment 5

[cmtalbert]

VERIFIED on 0.3.1 -- Lightning: 2007020304 (Thunderbird: version 2 beta 2
(20070131)) AND on Sunbird: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
en-US; rv:1.9a1) Gecko/20070203 Sunbird/0.3.1

(needs Verifying on 0.5)

Comment 6

[Martin Schröder [:mschroeder]]

VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre.