Closed Bug 369048 Opened 18 years ago Closed 18 years ago

The installer should take over system wide defaults on install if the existing system wide default is for a firefox.exe

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: verified1.8.1.2, Whiteboard: [vista])

Attachments

(1 file, 1 obsolete file)

patch as checked in
8.18 KB, patch
robert.strong.bugs
: review+
dveditz
: approval1.8.1.2+
Details | Diff | Splinter Review 
Due to Vista compatibility we need to set system wide defaults during install if the previous install is for a side by side install or the existing install location. This will allow getting to a known good state by just running the installer. Patch coming up.
Flags: blocking1.8.1.2?
OS: Windows XP → Windows Vista
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #253731 -
        Flags: review?(sspitzer)

    
    

    
  
Comment on attachment 253731 [details] [diff] [review]
patch

r=sspitzer

        Attachment #253731 -
        Flags: review?(sspitzer) → review+

    
    

    
  
Checked in to trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

        Attachment #253731 -
        Flags: approval1.8.1.2?

    
    

    
  


  
Received verbal from sspitzer for the one line addition to uninstaller.nsi

        Attachment #253731 -
        Attachment is obsolete: true

        Attachment #253734 -
        Flags: review+

        Attachment #253734 -
        Flags: approval1.8.1.2?

        Attachment #253731 -
        Flags: approval1.8.1.2?
Flags: blocking1.8.1.2? → blocking1.8.1.2+

    
    

    
  
Comment on attachment 253734 [details] [diff] [review]
patch as checked in

a=dveditz for drivers

        Attachment #253734 -
        Flags: approval1.8.1.2? → approval1.8.1.2+
Depends on: 369314

    
  
Whiteboard: [vista]

    
    

    
  
fixed on the branch.
Keywords: fixed1.8.1.2
Blocks: 369465
No longer blocks: 352420

    
    

    
  
Verified fixed for 1.8.1.2

I`ve done some tests with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a3pre) Gecko/2007020704 Minefield/3.0a3pre running as default browser and then a new download and install of Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.2pre) Gecko/2007020804 BonEcho/2.0.0.2pre

1.8.1.2 was set to default after the installation, like expected.
Keywords: fixed1.8.1.2 → verified1.8.1.2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: