369097 - Only escape % in to-be-evaluated JavaScript code

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Simon Bünzli]

Steps to reproduce:
1. Open the Error Console
2. Evaluate [""]..length

Expected result:
Error: XML descendants internal method called on incompatible Array
Source file: javascript: [""]..length

Actual result:
Source file: javascript: %5B%22%22%5D..length

Suggested solution:
Instead of encodeURIComponent, using .replace(/%/g, "%25") should be sufficient (that's what Console² does).

From bug 342662 comment #12:
If you want to be sure about non-ASCII Unicode characters, what about
.replace(/[^\x20-\x24\x26-\x7F]+/g, encodeURI) as a compromise? This encodes
everything except printable 7-bit-ASCII characters (% being the exception to
the exception).

OTOH I haven't seen any bug report to that end so far and we haven't encoded
any (Unicode) characters since day 0, so we might just as well escape only that
one character (which shouldn't make much of a difference) and wait for further
bug reports such as this one [i.e. bug 342662] about other characters.

Comment 1

[Simon Bünzli]

Attachment: fix

Comment 2

[[e-mail]]

Comment on attachment 264504 [details] [diff] [review]
fix

Evaluator.location ;-)

Comment 3

[Simon Bünzli]

Attachment: evaluator.location (fix unbitrotted)

Comment 4

[Nickolay_Ponomarev]

mozilla/toolkit/components/console/content/console.js         1.9
mozilla/xpfe/components/console/resources/content/console.js  1.28