369125 - updater.exe doesn't have a good description ("updater")

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

updater.exe doesn't have a good description ("updater")

this should be fixed on trunk and MOZILLA_1_8_BRANCH.

good news is rob has a fix!

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot, but this is more critial for Vista than for Windows XP

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Benjamin, we'd like to add a description to updater.exe since this is displayed in the UAC dialog... currently it just displays "updater" and for the branch we'd like it to display "Software Updater". I've tested that this does the right thing.

btw: I think it might be a good thing to add the ability to preprocess module.ver so we don't have to change it for app's for each release... I'll look into it as time permits.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 253791 [details] [diff] [review]
patch

changing review to Seth since I'd like to get this landed on trunk tonight.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 253791 [details] [diff] [review]
patch

r=sspitzer

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to trunk. This will be seen in the nightly tomorrow

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 253791 [details] [diff] [review]
patch

a=dveditz for the 1.8 branch.

Is "software updater" really all that much better than "updater"?

Comment 7

[Robert Strong (they/them - no direct email)]

It was just the exe name of "up0dater" and with the patch it is "Software Updater" which will be displayed below the company name. Not much better and I am planning on making it so the module.ver can be preprocessed so it can be "AppName Software Updater" for 3.0

Comment 8

[(not reading, please use [e-mail] instead)]

fixed on the branch.

Comment 9

[Carsten Book [:Tomcat]]

Verified fixed for trunk and 1.8.1.2 on Vista and XP x64 with 

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre ID:2007020703

and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a2pre) Gecko/2007020611 Minefield/3.0a2pre

update.exe description is now "Software Updater"