updater.exe doesn't have a good description ("updater")

VERIFIED FIXED

Status

()

Toolkit
Application Update
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: rstrong)

Tracking

({verified1.8.1.2})

1.8 Branch
x86
Windows Vista
verified1.8.1.2
Points:
---
Bug Flags:
blocking1.8.1.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [vista])

Attachments

(2 attachments)

updater.exe doesn't have a good description ("updater")

this should be fixed on trunk and MOZILLA_1_8_BRANCH.

good news is rob has a fix!
Flags: blocking1.8.1.2?
Created attachment 253780 [details]
screen shot, but this is more critial for Vista than for Windows XP
OS: Windows XP → Windows Vista

Updated

12 years ago
Flags: blocking1.8.1.2? → blocking1.8.1.2+
Created attachment 253791 [details] [diff] [review]
patch

Benjamin, we'd like to add a description to updater.exe since this is displayed in the UAC dialog... currently it just displays "updater" and for the branch we'd like it to display "Software Updater". I've tested that this does the right thing.

btw: I think it might be a good thing to add the ability to preprocess module.ver so we don't have to change it for app's for each release... I'll look into it as time permits.
Attachment #253791 - Flags: review?(benjamin)
Comment on attachment 253791 [details] [diff] [review]
patch

changing review to Seth since I'd like to get this landed on trunk tonight.
Attachment #253791 - Flags: review?(benjamin) → review?(sspitzer)
Comment on attachment 253791 [details] [diff] [review]
patch

r=sspitzer
Attachment #253791 - Flags: review?(sspitzer) → review+
Checked in to trunk. This will be seen in the nightly tomorrow
Blocks: 352420
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Attachment #253791 - Flags: approval1.8.1.2?
Comment on attachment 253791 [details] [diff] [review]
patch

a=dveditz for the 1.8 branch.

Is "software updater" really all that much better than "updater"?
Attachment #253791 - Flags: approval1.8.1.2? → approval1.8.1.2+
It was just the exe name of "up0dater" and with the patch it is "Software Updater" which will be displayed below the company name. Not much better and I am planning on making it so the module.ver can be preprocessed so it can be "AppName Software Updater" for 3.0

Updated

12 years ago
Whiteboard: [vista]
fixed on the branch.
Keywords: fixed1.8.1.2
Blocks: 369465
No longer blocks: 352420
Verified fixed for trunk and 1.8.1.2 on Vista and XP x64 with 

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre ID:2007020703

and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a2pre) Gecko/2007020611 Minefield/3.0a2pre

update.exe description is now "Software Updater"
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.