Closed
Bug 369127
Opened 18 years ago
Closed 18 years ago
[FIX]Bug 243370 landing regressed tests from bug 335628
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
2.60 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
See bug 335628 comment 3 and following. I should note that those tests were in the tree by the time the patch in question was posted... We should really make people run tests before landing changes like this, imo. :(
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #253792 -
Flags: superreview?(roc)
Attachment #253792 -
Flags: review?(roc)
|
||
Comment 2•18 years ago
|
||
I found that one too when checking lxr again now. :-( The same patch is embedded in the latest patch (part 3) in bug 243370. I've tried making the tests work on my devel box, but the old Pango I'm stuck with falls to pieces for some reason. I can't change environment there, so my choices are to stop making patches or to devel without the tests. Two bad options.
|
|
Assignee | |
Comment 3•18 years ago
|
||
Huh. Which pango version do you have?
|
|
||
Comment 4•18 years ago
|
||
Pango 1.6.0.
|
|
Assignee | |
Comment 5•18 years ago
|
||
vlad, I thought we still supported pango 1.6?
Comment on attachment 253792 [details] [diff] [review] Fix r+sr=dbaron
Attachment #253792 -
Flags: superreview?(roc)
Attachment #253792 -
Flags: superreview+
Attachment #253792 -
Flags: review?(roc)
Attachment #253792 -
Flags: review+
|
|
Assignee | |
Comment 7•18 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•