369176 - "###!!! ASSERTION: continuing frame had more severe impact than first-in-flow" with block-in-inline, :after, wrapping

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: continuing frame had more severe impact than first-in-flow: '!frame->GetPrevContinuation()', file /Users/jruderman/trunk/mozilla/layout/base/nsFrameManager.cpp, line 1444

Comment 1

[Jesse Ruderman]

Attachment: testcase

Oops, I attached the wrong file earlier.

Comment 2

[Jesse Ruderman]

Attachment: testcase

The previous testcase depended on the width of the browser window being small.  This one doesn't.

Comment 3

[Boris Zbarsky [:bzbarsky]]

So this is a bit if a problem.  The issue is that we do the check for a missing :after frame on the last continuation only.  Which makes sense, but as a result the last continuation _can_ in fact produce a bigger hint than the previous ones.

The reason we hit it here with the no-op change is that the last continuation of the primary frame comes before the block in the {ib} split... and the :after comes inside the inline after that block.

I suppose we could try to detect that in the frame manager, which would fix this particular case, but not the general problem.  Then you'll need a testcase which actually changes whether :after applies to some stuff that's wrapped to assert.  ;)

Comment 4

[Jesse Ruderman]

I still see this bug on trunk.

Comment 5

[Jesse Ruderman]

Still happens on trunk.

Comment 6

[Jesse Ruderman]

WFM

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100602 Minefield/3.7a5pre

Comment 7

[Jesse Ruderman]

Crashtest: http://hg.mozilla.org/mozilla-central/rev/e5dd52dd3cb5