369210 - Maybe add |mk_add_options MOZ_MAKE_FLAGS="-s"| to tinderbox configs?

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, enhancement)

Description

[Jeff Walden [:Waldo]]

The -s flag to make causes it not to print out every command it executes, I believe, speeding up build times.  I don't know the total speedup, but for depend builds (and other cases where the bulk of time isn't spent executing commands) at the least it's probably a noticeable fraction of build time.  Try running |make check| and |make -s check| sometime in an --enable-tests build for an example.

The only downside is that you get less feedback about where an exact problem happens because you can't read a "now entering directory foo" message before it, but I think that problem's minor -- the error messages commands print are still printed, and they're usually enough to know where the problem lies.

Comment 1

[J. Paul Reed [:preed]]

I'm *really* tempted to WONTFIX this, for the reason you pointed out:

The only downside is that you get less feedback about where an exact problem
happens because you can't read a "now entering directory foo" message before
it,

Our major tinderbox problem is that it throws information away, so I think this moves us in the wrong direction.

Comment 2

[Jeff Walden [:Waldo]]

Something I didn't know about prior to filing the bug:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/config/rules.mk&rev=3.538&mark=65-70#59

I think the real question here is this: which particular commands, when they fail, aren't ELOG'd?  We should find out which commands fail with bad error messages and ELOG them instead of not enabling "-s".

Comment 3

[J. Paul Reed [:preed]]

WONTFIXing this, per comment 1.