Closed
Bug 369216
Opened 17 years ago
Closed 17 years ago
[FIX]Crash [@ NS_GetInnermostURI] when calling addBinding with null as the second parameter
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(4 keywords)
Crash Data
Attachments
(2 files)
|
71 bytes,
text/html
|
Details | |
|
955 bytes,
patch
|
jst
:
review+
jst
:
superreview+
dveditz
:
approval1.8.1.4+
dveditz
:
approval1.8.0.12+
|
Details | Diff | Splinter Review |
Loading the testcase triggers an assertion and a crash: ###!!! ASSERTION: Must have URI: 'uri', file ../../dist/include/necko/nsNetUtil.h, line 1280 Thread 0 Crashed: 0 libcaps.dylib 0x17999816 NS_GetInnermostURI(nsIURI*) + 124 (nsNetUtil.h:1284) 1 libcaps.dylib 0x179910a3 nsScriptSecurityManager::CheckLoadURIWithPrincipal(nsIPrincipal*, nsIURI*, unsigned) + 733 (nsScriptSecurityManager.cpp:1265) 2 libgklayout.dylib 0x187146f2 nsXBLService::LoadBindings(nsIContent*, nsIURI*, int, nsXBLBinding**, int*) + 520 (nsXBLService.cpp:577) 3 libgklayout.dylib 0x18716be0 nsBindingManager::AddLayeredBinding(nsIContent*, nsIURI*) + 186 (nsBindingManager.cpp:750) 4 libgklayout.dylib 0x18592dff nsDocument::AddBinding(nsIDOMElement*, nsAString_internal const&) + 327 (nsDocument.cpp:3322) 5 libxpcom_core.dylib 0x01651026 NS_InvokeByIndex + 98 (xptcinvoke_unixish_x86.cpp:179) 6 libxpconnect.dylib 0x1304586b XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) + 4797 (xpcwrappednative.cpp:2215) 7 libxpconnect.dylib 0x1304d2da XPC_WN_CallMethod(JSContext*, JSObject*, unsigned, long*, long*) + 398 (xpcwrappednativejsops.cpp:1470) 8 libmozjs.dylib 0x01354529 js_Invoke + 3284 (jsinterp.c:1348) ...
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: general → bzbarsky
Status: NEW → ASSIGNED
Attachment #253906 -
Flags: superreview?(jst)
Attachment #253906 -
Flags: review?(jst)
|
|
Assignee | |
Comment 2•17 years ago
|
||
We might want this on branches too...
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
OS: Mac OS X → All
Hardware: PC → All
Resolution: --- → FIXED
Summary: Crash [@ NS_GetInnermostURI] when calling addBinding with null as the second parameter → [FIX]Crash [@ NS_GetInnermostURI] when calling addBinding with null as the second parameter
Target Milestone: --- → mozilla1.9alpha
|
Reporter | |
Comment 3•17 years ago
|
||
This patch hasn't been checked in, has it?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•17 years ago
|
||
Er, yes. Oops.
|
||
Comment 5•17 years ago
|
||
Comment on attachment 253906 [details] [diff] [review] Simple fix r+sr=jst
Attachment #253906 -
Flags: superreview?(jst)
Attachment #253906 -
Flags: superreview+
Attachment #253906 -
Flags: review?(jst)
Attachment #253906 -
Flags: review+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Fixed.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•17 years ago
|
||
Comment on attachment 253906 [details] [diff] [review] Simple fix Like I said, we might want this on branches too... but the flags got lost somehow.
Attachment #253906 -
Flags: approval1.8.1.4?
Attachment #253906 -
Flags: approval1.8.0.12?
|
||
Comment 9•17 years ago
|
||
Comment on attachment 253906 [details] [diff] [review] Simple fix approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #253906 -
Flags: approval1.8.1.4?
Attachment #253906 -
Flags: approval1.8.1.4+
Attachment #253906 -
Flags: approval1.8.0.12?
Attachment #253906 -
Flags: approval1.8.0.12+
|
||
Comment 11•17 years ago
|
||
verified fixed 1.8.1.4 using testcase and build Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4pre) Gecko/2007043003 BonEcho/2.0.0.4pre and verified fixed 1.8.0.12 using testcase and Build: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.12pre) Gecko/20070430 Firefox/1.5.0.12pre -> no crash on testcase -> adding verified keyword
|
||
Updated•13 years ago
|
Crash Signature: [@ NS_GetInnermostURI]
You need to log in
before you can comment on or make changes to this bug.
Description
•