369217 - Changed case in functions name "LoadMsgWithRemoteContent()" != "loadMsgWithRemoteContent()"

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

In Mozilla_1.8.0_Branch the function is spelled "LoadMsgWithRemoteContent()", but in Mozilla_1.8_Branch the function is spelled "loadMsgWithRemoteContent()".

This case change breaks all Add-ons using the function (e.g. "Allow HTML temp").

Was it intended to change the case? Why?

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

In LXR both the upper case and the lower case can be found in 1.8_Branch.

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Maybe it's a result of Bug 246077

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

ah sorry - false Bug in comment #2

The problem could be the result of Bug 357321

Comment 4

[Scott MacGregor]

Moving off bugs that didn't make the deadline for Thunderbird 2. 

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

5 weeks ago I've reported this Bug and today we've still no Thunderbird 2.0 RC candidate. IMHO the functions case change breaks the API.

Scott, you could give a one sentence statement, if this case change was intended or not? 

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

5 weeks ago I've reported this Bug and today we've still no Thunderbird 2.0 RC candidate. IMHO the functions case change breaks the API.

Scott, you could give a one sentence statement, if this case change was intended or not?

Comment 7

[Scott MacGregor]

I found this addon by Alexander on the website:

https://addons.mozilla.org/thunderbird/1556/

There's a comment that says 'finaly fixed a bug with remote content code'. Does that mean you've worked around this in your extension?

Comment 8

[Scott MacGregor]

Attachment: capitalize the function to keep it in sync with seamonkey

Comment 9

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #7)
> There's a comment that says 'finaly fixed a bug with remote content code'. Does
> that mean you've worked around this in your extension?

At the moment (AllowHTMLtemp 1.0) the extension checks Thunderbirds version and build date to distinguish between the different cases.

Comment 10

[Scott MacGregor]

I can fix this for tb2 but you'd have to tweak your extension again. is that ok?

Comment 11

[Alex Ihrig [:Thunderbird_Mail_DE]]

I'll adapt the version/build check in the extension to match the correct case. Thanks

Comment 12

[Scott MacGregor]

Alexander, I apologize, but I'm still confused (it happens to me near release time :)). Would you like to see this patch still get checked in?

Thanks!
-Scott

Comment 13

[Alex Ihrig [:Thunderbird_Mail_DE]]

If the case change was not intended by any reason, than I'd like to see the checkin.

Comment 14

[Scott MacGregor]

fixed branch and trunk.

Comment 15

[Alex Ihrig [:Thunderbird_Mail_DE]]

Just wondering, what is with these two code lines in LXR:

/mailnews/base/resources/content/mailWindowOverlay.js, line 2187 -- * loadMsgWithRemoteContent

/mailnews/base/resources/content/mailWindowOverlay.js, line 2190 -- function loadMsgWithRemoteContent()

Comment 16

[Hermann Schwab]

didn't find it in lines 2187 and 2190, but lines 2278 and 2281

http://lxr.mozilla.org/mozilla/source/mail/base/content/mailWindowOverlay.js#2277

2277 /**
2278  * loadMsgWithRemoteContent
2279  *   Reload the current message, allowing remote content
2280  */
2281 function loadMsgWithRemoteContent()

Comment 17

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #16)
> didn't find it in lines 2187 and 2190, but lines 2278 and 2281

/mail/  is not  /mailnews/

Comment 18

[Jay Patel [:jay]]

v.fixed based on code inspection