369241 - MozillaBuild should prepend the PlatformSDK's paths if available for vc71

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Calling the Platform SDK's 'SetEnv.cmd' simply prepends some SDK paths and then calls 'vcvars.bat' in the appropriate place. We use the Platform SDK and need those additional paths in order to compile successfully. I don't know if this sort of thing is needed for VC6 or VC8, but for VC7 I'd like to propose the following patch.

Oh, and by the way, the line endings in this file are screwed up. The patch makes them all windows line endings. The basic change is this:

   rem Prepend MSVC paths
  +if "%SDKDIR%"=="" (
       call "%VC71DIR%\Bin\vcvars32.bat"
  +)
  +else (
  +    call "%SDKDIR%\SetEnv.cmd"
  +)

Comment 1

[Benjamin Smedberg]

Comment on attachment 253924 [details] [diff] [review]
Patch

The comment in the VC6 makefile is telling: the SDK is not determinite about *which* compiler will get chosen.

I don't really understand why you need the SDK (it shouldn't be necessary for compiling Mozilla that I know of), but if it is, instead of using SetEnv.cmd, please use the technique in start-msvc6.bat

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Ok, here we go. I never read the vc8 script before and totally missed that comment.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 253961 [details] [diff] [review]
Patch

Switching review to Ted due to bsmdeberg's leave.

Comment 4

[Benjamin Smedberg]

Comment on attachment 253961 [details] [diff] [review]
Patch

I don't think we want to include the SDK by default except when necessary (MSVC8 express). So either keep this as a private change for Songbird, or...

We can add the SDK if an environment variable like MOZ_USE_SDK is set. I would take something like that.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Ok, introduces the MOZBUILD_USE_SDK variable.

Comment 6

[Benjamin Smedberg]

Comment on attachment 257721 [details] [diff] [review]
Patch

Please land this ASAP.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on trunk.

Comment 8

[[e-mail] (:bhearsum)]

Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild