369245 - Use non-modal sheets for keychain form submit prompts

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: OS Integration, defect)

Description

[Stuart Morgan]

We are using the skanky modal sheets for the "do you want to save/update this password" dialogs triggered by form submits, but since Gecko isn't waiting for a return value they should be replaceable with normal sheets.

Comment 1

[Stuart Morgan]

Note to self: see also nsIAuthPrompt2, and whether we can do async auth for HTTP auth too.

Comment 2

[Stuart Morgan]

Attachment: fix for store and update [landed]

This moves the Store and Update prompts over to NSAlert, giving us:
- fewer uses of the skanky modal sheet method
- less to maintain in the nib (it's all strings now)
- page loading under the sheet, making it possible to wait and see if you had the right password before choosing to save.

Unfortunately I couldn't get rid of the nib entirely due to the "this form has changed" sheet, which is trickier. I'll leave this open to consider that and HTTPAuth, but this is the bulk of the win so it should go in now rather than waiting for the rest.

Comment 3

[Stuart Morgan]

Attachment: corresponding nib [landed]

Comment 4

[Stuart Morgan]

Attachment: corresponding strings [landed]

The new Localizable.strings file, for testing. It's ripped verbatim from the nib, so nothing interesting there.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 277202 [details] [diff] [review]
fix for store and update [landed]

rs=pink

Comment 6

[Stuart Morgan]

Comment on attachment 277202 [details] [diff] [review]
fix for store and update [landed]

Landed on trunk and MOZILLA_1_8_BRANCH; leaving open for remaining work.