Use non-modal sheets for keychain form submit prompts

NEW
Unassigned

Status

Camino Graveyard
OS Integration
12 years ago
8 years ago

People

(Reporter: Stuart Morgan, Unassigned)

Tracking

Details

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
We are using the skanky modal sheets for the "do you want to save/update this password" dialogs triggered by form submits, but since Gecko isn't waiting for a return value they should be replaceable with normal sheets.
(Reporter)

Comment 1

11 years ago
Note to self: see also nsIAuthPrompt2, and whether we can do async auth for HTTP auth too.
(Reporter)

Comment 2

11 years ago
Created attachment 277202 [details] [diff] [review]
fix for store and update [landed]

This moves the Store and Update prompts over to NSAlert, giving us:
- fewer uses of the skanky modal sheet method
- less to maintain in the nib (it's all strings now)
- page loading under the sheet, making it possible to wait and see if you had the right password before choosing to save.

Unfortunately I couldn't get rid of the nib entirely due to the "this form has changed" sheet, which is trickier. I'll leave this open to consider that and HTTPAuth, but this is the bulk of the win so it should go in now rather than waiting for the rest.
Attachment #277202 - Flags: review?(joshmoz)
(Reporter)

Comment 3

11 years ago
Created attachment 277203 [details]
corresponding nib [landed]
(Reporter)

Comment 4

11 years ago
Created attachment 277204 [details]
corresponding strings [landed]

The new Localizable.strings file, for testing. It's ripped verbatim from the nib, so nothing interesting there.

Updated

11 years ago
Attachment #277202 - Flags: review?(joshmoz) → review+
(Reporter)

Updated

11 years ago
Attachment #277202 - Flags: superreview?(mikepinkerton)
Comment on attachment 277202 [details] [diff] [review]
fix for store and update [landed]

rs=pink
Attachment #277202 - Flags: superreview?(mikepinkerton) → superreview+
(Reporter)

Comment 6

11 years ago
Comment on attachment 277202 [details] [diff] [review]
fix for store and update [landed]

Landed on trunk and MOZILLA_1_8_BRANCH; leaving open for remaining work.
Attachment #277202 - Attachment description: fix for store and update → fix for store and update [landed]
(Reporter)

Updated

11 years ago
Attachment #277203 - Attachment description: corresponding nib → corresponding nib [landed]
(Reporter)

Updated

11 years ago
Attachment #277204 - Attachment description: corresponding strings → corresponding strings [landed]
(Reporter)

Updated

9 years ago
Assignee: stuart.morgan+bugzilla → nobody
You need to log in before you can comment on or make changes to this bug.