36935 - [i18n] Textwidget doesn't scroll when non-7-bit-ascii chars are entered

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Adam Sjøgren]

When a textwidget is full of chars, it scrolls when you enter more text. Unless
you enter a non-7-bit-ascii letter (like "æ" (&aelig, a common Danish national
char)), then the text doesn't scroll to the left until you enter another
7-bit-ascii char, then the text scrolls two chars.

An example page is at <URL:http://www.koldfront.dk/mozilla/M15/textwidget.html>

I'm using Mozilla M15 on a Debian GNU/Linux 2.2 box.

Comment 1

[Kathleen :Brade]

reassign to kin for m16

Comment 2

[kinmoz]

Accepting bug.

Comment 3

[rubydoo123]

moving to m17

Comment 4

[ekrock's old account (dead)]

nsbeta2 6/1-. Correct handling of international text input in html32 forms.

Comment 5

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 6

[rubydoo123]

m16

Comment 7

[kinmoz]

So how exactly does one enter an "æ" from a U.S. keyboard? (Note: I did a 
copy/paste to get the one in the previous sentence.)

Comment 8

[kinmoz]

Okay, I think I've figured out how to do it, I just had to run:

  xmodmap -n -e "keysym Control_R = Multi_key"

to map my control key to the Multi key. Now typing Multi-A-E gives me "æ".

Note: Using the Multi-Key does not work in Ender-Lite widgets. I'll file a
seperate bug on that.

Comment 9

[kinmoz]

I have a real simple fix for this. I will check it in as soon as I can after
[e-mail] reviews it.

For the curious, the fix involves making an existing method
(ScrollSelectionIntoView()) on one of our listener classes a static function so
that it can be used by all our listeners. The next step was to call this static
function from nsTextEditorTextListener::HandleText().

Comment 10

[kinmoz]

Attachment: Patch that fixes the problem.

Comment 11

[Joe Francis]

reviewed by jfrancis

Comment 12

[kinmoz]

Fix checked in:

Made ScrollSelectionIntoView() a static function and called it from 
HandleText().
    editor/base/nsEditorEventListeners.cpp
    editor/base/nsEditorEventListeners.h

r=[e-mail]  a=[e-mail]

Comment 13

[Teruko Kobayashi]

I verified this in 2000-05-31-08 Linux build.

Comment 14

[Hidetoshi Tajima]

*** Bug 38596 has been marked as a duplicate of this bug. ***