Status
()
People
(Reporter: moco, Assigned: rstrong)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(URL)
Attachments
(1 attachment)
|
751 bytes,
patch
|
Dolske
:
review+
rcampbell
:
feedback+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
improve CRC error value
right now, we do:
777 // Verify that the contents of the source file correspond to what we expect.
778
779 unsigned int crc = crc32(buf, header.slen);
780
781 if (crc != header.scrc32) {
782 LOG(("CRC check failed\n"));
783 return CRC_ERROR;
784 }
785
we could at least log the two crc values.
|
(Reporter) | |
Comment 1•12 years ago
|
||
this would be useful in tracking down the automation failure that rob and rob are seeing. my wild $1 guess says that header src is 0.
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
|
(Assignee) | |
Comment 2•8 years ago
|
||
Created attachment 498573 [details] [diff] [review] patch rev 1 Sample output: LoadSourceFile: destination file crc -1141869618 does not match expected crc -2130395286
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #498573 -
Flags: review?(dolske)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 498573 [details] [diff] [review] patch rev 1 looks good to me.
Attachment #498573 -
Flags: feedback+
|
|
(Assignee) | |
Comment 4•8 years ago
|
||
Comment on attachment 498573 [details] [diff] [review] patch rev 1 Dave, simple patch that improves diagnosing update problems. Thought you might be able to give a quick r and a +
Attachment #498573 -
Flags: review?(dolske) → review?(dtownsend)
|
||
Updated•8 years ago
|
Attachment #498573 -
Flags: review?(dtownsend) → review+
|
|
(Assignee) | |
Updated•8 years ago
|
Attachment #498573 -
Flags: approval2.0?
|
||
Updated•8 years ago
|
Attachment #498573 -
Flags: approval2.0? → approval2.0+
|
|
(Assignee) | |
Comment 5•8 years ago
|
||
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/19df7ba36bc4
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•