369411 - improve CRC error value

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

improve CRC error value

right now, we do:

777   // Verify that the contents of the source file correspond to what we expect.
778 
779   unsigned int crc = crc32(buf, header.slen);
780 
781   if (crc != header.scrc32) {
782     LOG(("CRC check failed\n"));
783     return CRC_ERROR;
784   }
785   

we could at least log the two crc values.

Comment 1

[(not reading, please use [e-mail] instead)]

this would be useful in tracking down the automation failure that rob and rob are seeing.

my wild $1 guess says that header src is 0.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev 1

Sample output:
LoadSourceFile: destination file crc -1141869618 does not match expected crc -2130395286

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 498573 [details] [diff] [review]
patch rev 1

looks good to me.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 498573 [details] [diff] [review]
patch rev 1

Dave, simple patch that improves diagnosing update problems. Thought you might be able to give a quick r and a +

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/19df7ba36bc4