369449 - quickparse should show binaryurl

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Robert Helmer [:rhelmer]]

The quickparse page should show the contents of binaryurl in one of the columns, e.g.:

Build|Firefox|Linux argo-vm Depend Nightly|success|1170741360|http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2007-02-05-04-trunk/

This would make it much easier to track builds for testing purposes.

Comment 1

[Reed Loden [:reed]]

I have a feeling you'll break lots of things if you added that. Mozbot and TinderStatus are two things that would most likely be broken if any change was made to the format of that file.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to comment #1)
> I have a feeling you'll break lots of things if you added that. Mozbot and
> TinderStatus are two things that would most likely be broken if any change was
> made to the format of that file.

As long as they are only looking at the columns they are interested in, they should be fine. They were both fine after I added the buildID column, for example.

Comment 3

[cls]

Attachment: v1.0

Adds a url_encoded binaryurl column to the quickparse output.

Modified tb_loadquickparseinfo() to use a hash of hashes rather than using a single hash for each field we want to return.

Comment 4

[Mike Taylor [:bear]]

Comment on attachment 254584 [details] [diff] [review]
v1.0

There is another call to tb_loadquickparseinfo():

addnote.cgi line 176

other than that r+

Comment 5

[cls]

Attachment: v1.1

Good catch.

Comment 6

[cls]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fwebtools%2Ftinderbox&file=&filetype=match&who=cls%25seawood.org&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-09+16%3A37&maxdate=2007-02-09+16%3A39&cvsroot=%2Fcvsroot