Closed Bug 369449 Opened 16 years ago Closed 16 years ago

quickparse should show binaryurl

Categories

(Webtools Graveyard :: Tinderbox, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: rhelmer)

Details

Attachments

(1 file, 1 obsolete file)

11.11 KB, patch
bear
: review+
Details | Diff | Splinter Review
The quickparse page should show the contents of binaryurl in one of the columns, e.g.:

Build|Firefox|Linux argo-vm Depend Nightly|success|1170741360|http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2007-02-05-04-trunk/

This would make it much easier to track builds for testing purposes.
I have a feeling you'll break lots of things if you added that. Mozbot and TinderStatus are two things that would most likely be broken if any change was made to the format of that file.
(In reply to comment #1)
> I have a feeling you'll break lots of things if you added that. Mozbot and
> TinderStatus are two things that would most likely be broken if any change was
> made to the format of that file.

As long as they are only looking at the columns they are interested in, they should be fine. They were both fine after I added the buildID column, for example.
Assignee: morgamic → rhelmer
Attached patch v1.0 (obsolete) — Splinter Review
Adds a url_encoded binaryurl column to the quickparse output.

Modified tb_loadquickparseinfo() to use a hash of hashes rather than using a single hash for each field we want to return.
Attachment #254584 - Flags: review?(bear)
Comment on attachment 254584 [details] [diff] [review]
v1.0

There is another call to tb_loadquickparseinfo():

addnote.cgi line 176

other than that r+
Attachment #254584 - Flags: review?(bear) → review-
Attached patch v1.1Splinter Review
Good catch.
Attachment #254584 - Attachment is obsolete: true
Attachment #254591 - Flags: review?(bear)
Attachment #254591 - Flags: review?(bear) → review+
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.