When setting default browser first clean up HKCU keys

RESOLVED FIXED in Firefox 2

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

({verified1.8.1.2})

Trunk
Firefox 2
x86
Windows XP
verified1.8.1.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We need this to properly set the default app when it was set under HKCU previously and the user is given admin rights.
this fixed on the branch, but not trunk yet.

robert is forward porting the fix to the trunk
Keywords: fixed1.8.1.2
Target Milestone: --- → Firefox 2
Comment on attachment 254133 [details] [diff] [review]
patch

r=sspitzer
Attachment #254133 - Flags: review?(sspitzer) → review+
I'll land this on the trunk after it re-opens
Blocks: 369465
No longer blocks: 352420
Checked in to trunk
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 6

12 years ago
rstrong/seth:  I was trying to verify this bug, but could not get anything to create keys in HKCU.  What would normally create the keys there that we want to clean up?
For the purposes of verification you could set them manually. Alternatively, on WinXP as admin you could set IE as the default browser, as a regular user set Firefox as the default browser (this should create the keys under HKCU), grant the regular user admin rights, change the default value under HKCU Software\Classes\http\shell\open\command, and then set Firefox as the default browser.
btw: this will only remove the values which is the minimum necessary. We will add the ability to remove empty keys as part of bug 369770.

Comment 9

12 years ago
(In reply to comment #8)
> btw: this will only remove the values which is the minimum necessary. We will
> add the ability to remove empty keys as part of bug 369770.
> 

In that case, I already verified this by adding my own keys and values as you suggested, where the values were removed when setting Firefox to default.  I just got confused when the keys remained (and were even taken over by IE if I switched the default back).

v.fixed with Firefox 2.0.0.2 rc2.
Keywords: fixed1.8.1.2 → verified1.8.1.2
You need to log in before you can comment on or make changes to this bug.