369520 - Bon Echo nighty will not run on win9x

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Richard]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-GB; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-GB; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7

update my nighty Bon Echo from 5th Feb to todays it refuses to run.
Vista checkins maybe !

Reproducible: Always

Steps to Reproduce:
1.
2.
3.


Expected Results:  
 Bon Echo runs on win9x

Comment 1

[Phil Ringnalda (:philor)]

Confirmed, downloaded latest-mozilla1.8's .zip on Win98 and it does nothing at all.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 3

[Jay Patel [:jay]]

Marcia/Juan:  We need to verify that this works for Windows 98 and ME once Rob lands his patch.  Please add it to the priority list of bugs to verify with RC1.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 254220 [details] [diff] [review]
patch

r=dveditz

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 254220 [details] [diff] [review]
patch

This is only needed on the branch since the trunk only supports versions of Windows with DuplicateTokenEx

Comment 6

[Jay Patel [:jay]]

Comment on attachment 254220 [details] [diff] [review]
patch

Approved for the 1.8 branch, a=jay.  Let's get this landed so QA/community can retest with tomorrow's nightlies (or RC1 if we get it).

Comment 7

[(not reading, please use [e-mail] instead)]

fwiw, r=sspitzer as well.  testing robert's 98.exe build now on Windows 98

Comment 8

[(not reading, please use [e-mail] instead)]

I have a windows 98 box (actually, it is QA's, thanks marcia!), but it is running an un-service-packed version (4.10.1998) of windows 98.

when I run robert's new 98.exe on it, I fail, but not because of DuplicateTokenEx().

I fail because firefox.exe is linked to missing export OLEAUT32.DLL -77

same is true with a branch build before robert's changes.

robert believes that we need a version of windows 98 with service packs to properly test this.

Comment 9

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
> (From update of attachment 254220 [details] [diff] [review])
> Approved for the 1.8 branch, a=jay.  Let's get this landed so QA/community can
> retest with tomorrow's nightlies (or RC1 if we get it).
I'm going to hold off for the tree to stop burning.

Comment 10

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH - not needed for the trunk

Comment 11

[Richard]

Sorry Feb7th build will not run on win98se 
fully updated 
   

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: followup patch -w

Followup patch for additional issues found

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: patch with whitespace changes

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 254372 [details] [diff] [review]
followup patch -w

r=sspitzer, nice!

I also tested builds from robert on windows 98.

I was able to install, run, and do updates

Comment 15

[Jay Patel [:jay]]

Comment on attachment 254372 [details] [diff] [review]
followup patch -w

Approved for 1.8 branch, a=jay.

Comment 16

[Robert Strong (they/them - no direct email)]

Additional patch checked in to MOZILLA_1_8_BRANCH - not needed on the trunk

Comment 17

[Hermann Schwab]

tested using tinderbox zip builds, windows is win98 SP1 with some Updates, like IE5.5

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre

Not working: 1.8.1.2pre: 2007020703 filetime 04:57:28
    Working: 1.8.1.2pre: 2007020703 filetime 19:48:02

Seems Bug 305233 is fixed for trunk only (I can't test trunk, so I won't download)

Bug 305233 – pacifica tinderbox builds and Talkback.exe have wrong buildID, taken from last nightly

Comment 18

[Carsten Book [:Tomcat]]

Verified fixed for 1.8.1.2 using a Windows 98 Install running as VM.
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.2pre)
Gecko/2007020804 BonEcho/2.0.0.2pre

I can launch and use the BonEcho nightly on Windows 98.