369539 - ChatZilla counts users outside the channel in its user count

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

Steps to reproduce:
1. Open ChatZilla
2. Connect to a channel where chanserv will op/halfop/voice you.
3. Notice the channel user count exceeds the actual user count by 1, because CZ now counts chanserv.

We should fix this, imho, by making new CIRCChanUser(stuff) not default to adding a user to the channel user list, and add a param that forces it to do so, which should only be true for the /names reply and JOIN message parsing.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

This should do.

Comment 2

[:Gijs (he/him)]

Comment on attachment 267057 [details] [diff] [review]
Patch

Except it doesn't. Sigh. Not sure why, but new users aren't being added to the user list here, for whatever reason - doing a /names fixes it. (I just randomly happened to run a build with this fix in it)

Comment 3

[:Gijs (he/him)]

Attachment: Patch

So, the trick is that I was passing "null" as the parameter for "modes". This b0rks the new CIRCChanUser code because it expects that the param you hand it is "undefined" if there is no data. If it isn't, it gets handed to arrayContains, which will hand it to arrayIndexOf, which will complain that you can't possibly expect it to do something useful with "for x in null".

I don't dare to touch the CIRCChanUser code, so I just pass undefined instead in this patch. And now it works.

Comment 4

[James Ross]

Comment on attachment 278042 [details] [diff] [review]
Patch

r=silver, on the condition you remove the "|| (this.canonicalName in parent.users)" bit. This is never true at this point.

Comment 5

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/js/lib/irc.js;
/cvsroot/mozilla/extensions/irc/js/lib/irc.js,v  <--  irc.js
new revision: 1.107; previous revision: 1.106
done