36954 - Japanese(Shift_JIS) char coding menu missing on Linux, random others missing on other platforms

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Charles Wang]

Ovserved on 2000-04-24-09-M16 comm build.

steps to reproduce:

1. Choose View via task bar
2. Character Coding-->Mutibyte

actual result:Japanese (Shift_JIS) text is missing from Multibyte's listing.
Expected result:Japanese (Shift_JIS) text should be listed if clicking Multibyte 
label

Comment 1

[Frank Tang]

Is that true the Shift_JIS move other places in the menu ? Is that esay to spot 
or not ?
cata can you talk to cwang about this issue. Is this the *feature* that you 
implement the dynamic menu ? 

Comment 2

[Frank Tang]

reassign to cata

Comment 3

[cata]

This should be fixed as today's build. Works fine in my tree. Please let me know 
if we have any problems.

Comment 4

[Charles Wang]

On my linux machine, it only shows Japanese-2022-JP and Japanese(UEC-JP)on 
todays build.

Comment 5

[cata]

Damn! Are you sure it is today's tree? I checked in this code last night. Any 
chance it didn't pick up the changes?

Comment 6

[Charles Wang]

It is missing only linux's build althouhg Cata marks fixed. I am going to watch 
it for the coming builds. XiangLan, would you please check your linux for this 
behavior on today's build? 

Comment 7

[ji]

Yes, it is missing on my linux build too. It shouldn't be a machine specific problem

Comment 8

[Charles Wang]

Thanks. If tomorrow is the same, we have to reopen this bug.

Comment 9

[Teruko Kobayashi]

This still happens in 2000042509 Linux build.  

Comment 10

[blee]

FYI, there's an extra Simp Chinese (GB2312) char coding menu in Linux bld. 
Editing Summary from "Character Coding's Multibyte is missing Japanese 
(Shift_JIS) text" to "Japanese(Shift_JIS) char coding menu missing in Linux bld"

Comment 11

[Phil Peterson]

[nsbeta2+]

Comment 12

[nhottanscp]

Similar problem in mail compose, gb2312 is missing from the menu (saw this in 
win32 build).

Comment 13

[nhottanscp]

Another problem in mail view, ISO-8859-1 is missing from the menu (saw this in 
win32 build).

Comment 14

[cata]

I'm chasing this baby as we speak...

Comment 15

[cata]

I have a fix for this:

S:\mozilla\intl\uconv\src>cvs diff -c *.cpp
Index: nsCharsetMenu.cpp
===================================================================
RCS file: /cvsroot/mozilla/intl/uconv/src/nsCharsetMenu.cpp,v
retrieving revision 1.32
diff -c -r1.32 nsCharsetMenu.cpp
*** nsCharsetMenu.cpp   2000/05/16 22:19:00     1.32
--- nsCharsetMenu.cpp   2000/05/18 23:11:50
***************
*** 942,948 ****
      // if this charset is not on the accepted list of charsets, ignore it
      PRInt32 index;
      res = aDecs->GetIndexOf(atom, &index);
!     if (NS_SUCCEEDED(res) && (index > 0)) {

        // else, add it to the menu
        res = AddCharsetToContainer(aRDFServ, aCCMan, aArray, aContainer, atom,

--- 942,948 ----
      // if this charset is not on the accepted list of charsets, ignore it
      PRInt32 index;
      res = aDecs->GetIndexOf(atom, &index);
!     if (NS_SUCCEEDED(res) && (index >= 0)) {

        // else, add it to the menu
        res = AddCharsetToContainer(aRDFServ, aCCMan, aArray, aContainer, atom,

Bob, how can we get this evaluated and checked in?
Guys, thanks a lot for catching this bug! Nasty one...

Comment 16

[cata]

Fixed...

Comment 17

[Katsuhiko Momoi]

*** Bug 41304 has been marked as a duplicate of this bug. ***

Comment 18

[Teruko Kobayashi]

I verified this in 2000-06-02-08 Linux build.