As per reed, filing a bug to implement the string changes he, timeless and I came up with to go with the upgrade. Most of the strings probably want to also be submitted upstream, but for now they'd need to be committed to bmo. The proposed changes are documented here in the first two tables: http://docs.google.com/Doc?id=dhmd4jxt_7gf3tpz Timeless - we didn't make any changes for 6. clicking cancel account link. Is that an email that is sent if someone clicks on the cancel link on the site?
I filed this while tired and forgot that we realized it *Wasn't* too late for upstream string changes, but I'll let reed make the component/summary changes as necessary since I suck at this :-p
Looks like this didn't get the components changed to be directed at upstream and I really don't know what they should be. Poking so we don't miss this.
Assignee: justdave → ui
Component: Bugzilla: Other b.m.o Issues → User Interface
Product: mozilla.org → Bugzilla
QA Contact: reed → default-qa
Target Milestone: --- → Bugzilla 3.2
Version: other → 2.23.4
Created attachment 271414 [details] [diff] [review] first attempt
Assignee: ui → timeless
Status: NEW → ASSIGNED
Attachment #271414 - Flags: review?(LpSolit)
Comment on attachment 271414 [details] [diff] [review] first attempt additional reviews can be used for anything, this is to see if i made any obvious goofs. note that "canceled" is consistently one l in the source base.
Comment on attachment 271414 [details] [diff] [review] first attempt >Index: template/en/default/account/email/confirm-new.html.tmpl >- <th align="right"><label for="realname">Real Name</label>:</th> >+ <th align="right"><i>(OPTIONAL)<label for="realname">Display Name</label></i>:</th> Nit: only put (OPTIONAL) between <i></i>. Also, I much prefer real name than display name as it would force users to put their real name instead of some random nick. >Index: template/en/default/account/email/request-new.txt.tmpl >+<b>PRIVACY NOTICE:</b> Bugzilla is an open bug system. All activity on any bug >+will be visible to the public, including email addresses. First of all, /(Bugzilla|bug)/ must be replaced by [% terms.$1 %]. Secondly, not all bug activity is visible to everybody as you can restrict bugs to some groups. Your wording is ambiguous, at least to me. Unfortunately >+at this time there is no option to hide email addresses and it is almost >+guaranteed that the address you use with Bugzilla will get spam. I don't like this warning about being spammed, but maybe it's just me. >+If the above links do not work, or you have any other issues regarding >+your account, please contact administration at [% Param('maintainer') %]. Why wouldn't it work? >Index: template/en/default/global/messages.html.tmpl >+ <a href="createaccount.cgi"> >+[% Param('urlbase') %]createaccount.cgi</a>. Use [% urlbase %] instead of [% Param('urlbase') %] so that is correctly chooses urlbase or sslbase based on settings.
Saying "Real Name" won't force people to use their real name. People are used to web forms and most know that there isn't a check. Saying "Real Name" locks in anyone that allows for other names, like BMO does here. If you really think that it's the right solution for everyone to try and lock people into using their real name, you should use different fields, First Name, Last Name, Job title etc. and don't make First Name and Last Name optional. Saying "Display Name" lets people know that this is what will be seen by other users. I think most implementations of bugzilla where the users want to use real names will know what they should fill in, if they should fill in real name and job title or real name and team, etc. Basically, while I disagree that you want to try and force people into using real names at the app level, if that is what you want to do, you want to do it differently than simply calling that field "Real Name."
Created attachment 272753 [details] [diff] [review] with minor revisions
Comment on attachment 272753 [details] [diff] [review] with minor revisions >Index: template/en/default/account/email/confirm-new.html.tmpl >- <th align="right"><label for="realname">Real Name</label>:</th> >+ <th align="right"><i>(OPTIONAL)</i><label for="realname">Display Name</label>:</th> I talked about this change on IRC with mkanat, and we both agree that we don't want this change. Moreover, you are not consistent with other places in Bugzilla where "Real name" is still displayed. >Index: template/en/default/account/email/request-new.txt.tmpl >+<b>PRIVACY NOTICE:</b> [% Terms.Bugzilla %] is an open [% Terms.bug %] >+tracking system. Generally, all activity on each [% Terms.bug %] >+will be visible to the public, including email addresses. Unfortunately >+at this time there is no option to hide email addresses and it is almost >+guaranteed that the address you use with [% Terms.Bugzilla %] will >+receive spam. >+ >+<b>We recommend</b> using a free web email service (such as Gmail, Yahoo, >+Hotmail, or similar) or another secondary account to avoid receiving >+excessive spam at your primary email address. Here too, mkanat and I both think this has nothing to do here. If you want to warn users about spam, then you should warn them *before* they type their email address in the form on createaccount.cgi, not after. So this notice, if we keep it, should be moved on the page when entering your email address. The email a user get when registering should remain small and simple.
Attachment #272753 - Flags: review?(LpSolit) → review-
The email was written with the case in mind of someone who gets signed up by someone else. I believe this is one of the "benefits" of the new system, someone can help a user complete the first step. If you look it's the same notice as on the page you're talking about.
Oh, and [% Terms.foo %] must be [% terms.foo %]
OK, well clearly sending HTML tags in a text/plain email doesn't make sense. (that alone is a perfectly good reason to r-). the goal of HTML and the spirit of the change would be that the message appears on the enter password confirm HTML page. I think a smaller note in the email wouldn't be unreasonable though. definitely slightly back to the drawing board.
Created attachment 273079 [details] [diff] [review] some bigger changes http://mxr-test.landfill.bugzilla.org/bugzilla/search?string=-mail&find=tmpl$&filter=[Ee]-?mail Found 8 matching lines in 7 files -mail http://mxr-test.landfill.bugzilla.org/bugzilla/search?string=mail%20address&find=tmpl$&filter=[Ee]-?mail Found 75 matching lines in 32 files mail address /template/en/default/account/create.html.tmpl, * line 41 -- a legitimate e-mail address. You will receive an email at this address * line 53 -- <b>E-mail address:</b> /template/en/default/account/email/confirm-new.html.tmpl, * line 19 -- # email: email address of the user account. * line 42 -- <th align="right">Email Address:</th> I intend as part of some other bug to add a spelling error for the (non) hyphen variant. but at this point given how few instances of - there are, I'm making this single code path consistent, because it's embarrassing that consecutive pages can't get it right. I've fixed the spelling of terms, removed the HTML from the email :), copied the text w/ HTML to the pre-page where lpsolit wants it, dropped the Display Name change - that will be addressed in another bug. I'm fixing some text which doesn't properly reflect emailsuffix existence and including the open system note only when the system is truly open. Obviously this is a template, so if the system is half open people can clone the template.... the text must be in at least one of the email or choose password pages failure to include it means that if Lucy signs up her younger brother using the personal address she has for her brother, he will miss the spam notification and be very unhappy with his older sister.
Comment on attachment 273079 [details] [diff] [review] some bigger changes >Index: template/en/default/account/create.html.tmpl The typo was already here, but while you are editing this template, could you please fix: <label for="passwd1">Re-type your password</label> and replace "passwd1" by "passwd2" in the for="" attribute? Else clicking this label gives the focus to the wrong password field. >Index: template/en/default/account/email/request-new.txt.tmpl >+If you did not receive this email >+before [%+ time2str("%B %o, %Y at %H:%M %Z", expiration_ts) %] or you >+wish to create an account using a different email address you can begin >+again by going to: This paragraph gives: If you did not receive this email before July 23rd, 2007 at 16:24 MEST or you wish to create an account using a different email address you can begin again by going to: The first two lines should be combined in a single one so that lines have approximatively the same length: If you did not receive this email before July 23rd, 2007 at 16:24 MEST or you wish to create an account using a different email address you can begin again by going to: >+PRIVACY NOTICE: [% terms.Bugzilla %] is an open [% terms.bug %] >+tracking system. Activity on most [% terms.bugs %], including email addresses, >+will be visible to the public. We recommend using a secondary account or Same problem here. You get: PRIVACY NOTICE: Bugzilla is an open bug tracking system. Activity on most bugs, including email addresses, will be visible to the public. We recommend using a secondary account or >Index: template/en/default/global/messages.html.tmpl >+ canceled. If you would like to create an account at this address in >+ the future, you will need to begin again at >+ <a href="createaccount.cgi"> >+ [% urlbase %]createaccount.cgi</a>. I don't think this link is useful as the user will probably not create an account right now. And if he does, then "in the future" is inappropriate. Anyway, this template doesn't pass tests because [% urlbase %] is not filtered. You must use |FILTER html|. Everything else looks good. The next patch should be the final one.
Attachment #273079 - Flags: review?(LpSolit) → review-
Created attachment 273376 [details] [diff] [review] those changes note that we can't seem to spell Re-type/Re-enter consistently. So i've switched to Confirm :).
Comment on attachment 273376 [details] [diff] [review] those changes >Index: template/en/default/account/email/request-new.txt.tmpl >+[% IF Param('createemailregexp') == '.*' && Param('emailsuffix') == '' %] >+PRIVACY NOTICE: [% terms.Bugzilla %] is an open [% terms.bug %] tracking system. Activity on most >+[% terms.bugs %], including email addresses, will be visible to the public. We recommend This last [% terms.bugs %] must be [%+ terms.bugs %], else no linebreak is added before this word and you get a huge single line. r=LpSolit with this "typo" fixed.
Attachment #273376 - Flags: review?(LpSolit) → review+
Comment on attachment 273376 [details] [diff] [review] those changes mozilla/webtools/bugzilla/template/en/default/account/prefs/account.html.tmpl 1.8 mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl 1.11 mozilla/webtools/bugzilla/template/en/default/account/created.html.tmpl 1.8 mozilla/webtools/bugzilla/template/en/default/account/email/confirm-new.html.tmpl 1.4 mozilla/webtools/bugzilla/template/en/default/account/email/request-new.txt.tmpl 1.5
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
I really don't like a lot of these changes. I'll either open another bug to change a lot of these or reopen this bug (leaning towards opening another one since this one is "fixed").
You need to log in before you can comment on or make changes to this bug.