369642 - L10n repackaging fails on uninst.exe

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[u60234]

Repackaging of Windows l10n builds on 1.8 branch is currently broken because it tries to copy a non-existent file, uninst.exe. From the latest tinderbox log for Mozilla1.8-l10n-sv-SE:
cp ../installer/windows/l10ngen/uninst.exe l10n-stage/localized/uninstall
cp: cannot stat `../installer/windows/l10ngen/uninst.exe': No such file or directory

It looks like browser/locales/Makefile.in on 1.8 branch needs to be made aware of the renaming of uninst.exe to helper.exe per bug 368353.

Trunk repackaging works OK.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch - branch only

Comment 2

[Jay Patel [:jay]]

Comment on attachment 254333 [details] [diff] [review]
patch - branch only

Approved for 1.8 branch, a=jay (as soon as preed gives the s= we should get this landed).

Comment 3

[J. Paul Reed [:preed]]

Comment on attachment 254333 [details] [diff] [review]
patch - branch only

You're a gentlemen and a scholar.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 254333 [details] [diff] [review]
patch - branch only

rob, should we add uninst.exe to the 
removed-files.in?

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
> (From update of attachment 254333 [details] [diff] [review])
> rob, should we add uninst.exe to the 
> removed-files.in?
We did. :)

Comment 6

[Robert Strong (they/them - no direct email)]

Fixed on MOZILLA_1_8_BRANCH