Closed Bug 369672 Opened 16 years ago Closed 16 years ago

Feed preview doesn't show dates when the timezone is specified as "UTC"

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ventnor.bugzilla, Unassigned)

References

()

Details

Attachments

(2 files, 1 obsolete file)

Attached patch One-line fix (obsolete) — Splinter Review
Click on the RSS feed in the URL. You'll notice that no dates are put into the preview, but when you view the source of the feed, dates are in fact given but with the timezone "UTC" rather than "UT" or "GMT". Our javascript Date() is fully capable of handling this so only our regular expression is stopping the date from being displayed.

I suspect other feeds use "UTC" as well.
Attachment #254376 - Flags: review?(sayrer)
Hi, I'm sorry I let this sit for so long. r=sayrer w/ a unit test added.
Attachment #254376 - Flags: review?(sayrer) → review+
Attached patch For checkinSplinter Review
Updated to tip
Attachment #254376 - Attachment is obsolete: true
Attached file Unit test
CVS hates me so I'm just going to post the unit test here. This goes in toolkit/components/feeds/test/xml/rss2/
Whiteboard: [checkin needed]
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.25; previous revision: 1.24
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_pubDate_utc.xml,v
done
Checking in test/xml/rss2/feed_pubDate_utc.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_pubDate_utc.xml,v  <--  feed_pubDate_utc.xml
initial revision: 1.1
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Whiteboard: [checkin needed]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.