when an engine update changes the engine's name, getEngineByName will only work with the old name

NEW
Unassigned

Status

()

defect
P4
minor
Rank:
45
13 years ago
4 years ago

People

(Reporter: moz-bugs, Unassigned)

Tracking

(Depends on 1 bug)

2.0 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070207 BonEcho/2.0.0.2pre

When Firefox updates a search engine and the name is changed by this update, the engineMetadataService does not update, meaning that nsISearchService::getEngineByName only works with the old name until Firefox is restarted.

Reproducible: Always
Looking at the code I cannot find a line where we update the engines name. Gavin or Ryan, is this still missing? Confirming for now.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 2.0 Branch
This really isn't a supported action. Until we fix bug 335102, we should probably just block such updates, similar to how we do it here: http://hg.mozilla.org/mozilla-central/annotate/072b936973fe/toolkit/components/search/nsSearchService.js#l1406 for updates to default engines that don't specify an updateURL.
Depends on: 335102
Priority: -- → P4
Whiteboard: [fxsearch]
Rank: 45
You need to log in before you can comment on or make changes to this bug.