369753 - remove nsIXMLContent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

http://lxr.mozilla.org/seamonkey/source/content/xml/content/public/nsIXMLContent.h#54
:)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

I'm not sure we want to move this to nsIContent....  Ideally we would just eliminate this method altogether.  I don't really like the way the sink currently has to know about it, basically.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I agree that this method should die. I have a plan for it, but it's sort of long term. So I think doing this for now is fine.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

And there is already nsIContent::IsLink(...)

Comment 5

[Boris Zbarsky [:bzbarsky]]

IsLink() is an entirely different thing -- we need it for various purposes (like CSS stuff).

I'll look at the patch in a bit.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 254432 [details] [diff] [review]
proposed patch

r+sr=bzbarsky

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

That dependency looks wrong given that this has been fixed long ago

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> That dependency looks wrong given that this has been fixed long ago

Not sure what the timing has to do with it... the patch for this bug caused bug 379159, so this bug "depends on" bug 379159, per the convention for marking regressions.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sorry, my bad