369908 - [0.3.1][mn] timezone selection box not shown in preference dialog

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; mn; rv:1.9a1) Gecko/20070208 Sunbird/0.3.1

Алдаа: гадаад оруулгын холболтыг боловсруулах алдаа
Эх файл: chrome://calendar/content/preferences/timezones.xul
Мөр: 46, Багана: 5
Эх бичлэг:
    %timezonesDTD;

Maybe encoding error in dtd file?

Comment 1

[Stefan Sitter [:ssitter]]

Not being able to select timezone should block 0.3.1 release for mn locale. Requesting blocking‑calendar0.3.1.

Comment 2

[Stefan Sitter [:ssitter]]

I copied the timezones.dtd from mn locale in an working en-US build. This way I got the following error message:

Error: error in processing external entity reference
Source File: chrome://calendar/content/preferences/timezones.xul
Line: 46, Column: 5
Source Code:
    %timezonesDTD;----^

I see that in timezones.dtd from mn locale there is a line break (<LF>) in pref.timezone.America.North_Dakota.New_Salem:
"Америк/North_Dakota/New_
Salem"

I wonder if this might be the cause of the error.

Comment 3

[Matthew (lilmatt) Willis]

(In reply to comment #2)
Stefan,
Nice catch.

I removed the line break and committed the change to SUNBIRD_0_3_BRANCH, LIGHTNING_0_3_BRANCH, MOZILLA_1_8_BRANCH, and trunk.

We'll see.

Comment 4

[Stefan Sitter [:ssitter]]

There is another error: The entity for Madeira is declared twice:

<!ENTITY pref.timezone.Atlantic.Madeira "Атлантын далайн/Madeira" >
<!ENTITY pref.timezone.Atlantic/Madeira "Атлантын далайн/Madeira" >

The second line with the '/' should be removed.

Comment 5

[Matthew (lilmatt) Willis]

(In reply to comment #4)
> The second line with the '/' should be removed.

Done on all 3 branches and trunk.

Comment 6

[Stefan Sitter [:ssitter]]

Works using Mozilla/5.0 (Windows; U; Windows NT 5.0; mn; rv:1.9a1) Gecko/20070213 Sunbird/0.3.1, the timezone preference dialog is displayed correct. Resolving FIXED and marking [fixed0.3.1].