369959 - Backspace deletes the character in front of the caret, after deleting a span

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Uri Bernstein]

Steps to reproduce:

- Open attachment 254610 [details] (from bug 369938, reported by Tom L. Snyder).
- Place the caret right before the "b" in "backspace" on the first line.
- Press backspace 8 times.
- Notice that the "b" was deleted.

This regressed between 2006-08-21-04 and 2006-08-22-04:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-21+03%3A00+&maxdate=2006-08-22+05%3A00+&cvsroot=%2Fcvsroot
Nothing in this range seems obvious.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Narrowed down a bit: 2006-08-21:14 - 2006-08-21:16
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-08-21+13%3A00&maxdate=2006-08-21+17%3A00

Comment 2

[Uri Bernstein]

Looks like a regression from bug 348854.

Comment 3

[Uri Bernstein]

Attachment: patch

The is what the patch to bug 345587 originally had.
The patch in bug 348854 added a GetCharAfter() instead of a GetCharBefore().

Comment 4

[Brett Wilson]

Comment on attachment 254658 [details] [diff] [review]
patch

Looks good.

Comment 5

[Uri Bernstein]

Checking in mozilla/editor/libeditor/html/nsWSRunObject.cpp;
/cvsroot/mozilla/editor/libeditor/html/nsWSRunObject.cpp,v  <--  nsWSRunObject.cpp
new revision: 1.43; previous revision: 1.42