Closed
Bug 369982
Opened 18 years ago
Closed 18 years ago
Meaningless column in userprefs.cgi if the user cannot share his saved searches
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
()
Details
(Keywords: polish, ue)
Attachments
(1 file, 1 obsolete file)
|
2.03 KB,
patch
|
wicked
:
review+
|
Details | Diff | Splinter Review |
If a user has not enough privs to share his saved searches, then the table displaying all his saved searches in userprefs.cgi has a column full of --- with no column title. That's confusing, is useless and should be removed.
Attachment #254656 -
Flags: review?(bugzilla-mozilla)
|
Assignee | |
Updated•18 years ago
|
Attachment #254656 -
Flags: review?(wicked+bz)
|
||
Comment 1•18 years ago
|
||
Comment on attachment 254656 [details] [diff] [review]
patch, v1
If the user is not in the group then the queryshare_groups will be empty so you should combine may_share with the check for size of that variable. This makes the UNLESS and explanatory text at line 53, the inner IF at line 110 and mdash at line 120 useless.
Attachment #254656 -
Flags: review?(wicked+bz)
Attachment #254656 -
Flags: review?(bugzilla-mozilla)
Attachment #254656 -
Flags: review-
|
|
Assignee | |
Comment 2•18 years ago
|
||
good idea.
Attachment #254656 -
Attachment is obsolete: true
Attachment #256291 -
Flags: review?(wicked+bz)
|
|
||
Updated•18 years ago
|
Attachment #256291 -
Flags: review?(wicked+bz) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Holding approval till 3.0 RC1 is released (to avoid any last minute regression).
Flags: approval?
|
||
Updated•18 years ago
|
Flags: approval3.0?
|
|
Assignee | |
Updated•18 years ago
|
Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval+
|
|
Assignee | |
Comment 4•18 years ago
|
||
tip:
Checking in template/en/default/account/prefs/saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v <-- saved-searches.html.tmpl
new revision: 1.12; previous revision: 1.11
done
3.0 RC1:
Checking in template/en/default/account/prefs/saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v <-- saved-searches.html.tmpl
new revision: 1.11.2.1; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•