370004 - Overriding the default attribute map on a per-LDAP directory basis won't work.

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

If I have a LDAP server ldap_2.servers.foo and I define ldap_2.servers.foo.attrmap.Custom4 to only override the attribute for that server,  it doesn't override the ldap_2.servers.default.attrmap.Custom4 value.

Basically, we're passing the wrong pref name to get the full attribute map - we're passing ldap_2.servers.foo.maxHits instead of ldap_2.servers.foo. This isn't a regression - it seems to have been wrong from the time when we got the attribute map code.

The attached patch changes the call to use m_DirPrefId which is the proper thing to use (in theory the code that gets maxHits could be simplified as well, but I'll address that in a separate bug).

Comment 1

[David :Bienvenu]

Comment on attachment 254678 [details] [diff] [review]
The fix

thx, Mark!

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 254678 [details] [diff] [review]
The fix

Patch checked into trunk. Requesting approval for 1.8 branch.

Comment 3

[Mark Banner (:standard8)]

Fixed on trunk.

Comment 4

[Mark Banner (:standard8)]

Checked into 1.8 branch.