Closed Bug 370015 Opened 17 years ago Closed 17 years ago

Duplicate 'Options' and 'Account Settings' items under Edit menu

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird2.0

People

(Reporter: koubekk, Assigned: mscott)

References

Details

(Keywords: regression, verified1.8.1.3)

Attachments

(2 files)

Duplicate Options preference
32.04 KB, image/png
Details
Patch
1.35 KB, patch
mscott
: review+
mscott
: approval-thunderbird2+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: version 2 beta 2 (2007021003)

In main mail window, under 'Edit' menu, there is a duplicate 'Options' preference (moreover with no descriptive text) down at the last position. When clicked, it opens the Options window, same as Tools -> Options.

Reproducible: Always




An attachment follows. Also tested on a fresh new profile without any extension (CuteMenus, etc.) - it's still there albeit smaller.

    
    

    
  
Confirming with 3.0a1 2007021010. Happens both on trunk and branch.

The "Account Settings..." item shouldn't be there either. It looks like the patch for bug 257885 accidentally indented the #ifdef/#ifndef around those two items, causing the preprocessor to ignore them.
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  

        Attachment #254712 -
        Flags: review?(mscott)

    
  
Summary: Duplicate unlabeled 'Options' preference under 'Edit' menu, main mail window → Duplicate 'Options' and 'Account Settings' items under Edit menu

    
  
Flags: blocking-thunderbird2?
Keywords: regression
Target Milestone: --- → Thunderbird2.0

    
  
Flags: blocking-thunderbird2? → blocking-thunderbird2+

    
    

    
  
Comment on attachment 254712 [details] [diff] [review]
Patch

thanks for catching this hasse!

        Attachment #254712 -
        Flags: review?(mscott)

        Attachment #254712 -
        Flags: review+

        Attachment #254712 -
        Flags: approval-thunderbird2+

    
  
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.3
Resolution: --- → FIXED

    
    

    
  
verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 ID:2007032620 - no duplicate options menu on Thunderbird 2 RC
Keywords: fixed1.8.1.3 → verified1.8.1.3

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: