370035 - Remove the aWidget parameter to nsIDeviceContextSpec::Init

Status: RESOLVED FIXED

(Core :: Widget, defect, P5)

Description

[Eli Friedman]

Nothing uses the aWidget parameter to nsIDeviceContextSpec::Init, so we should remove it.

I'll make a patch after Bug 370029 gets checked in.

(I'd like to get rid of the aIsPrintPreview parameter, but it's not really a priority, and it would be more difficult to do because it's used on Windows and OS/2.)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:spohl, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 2

[Dmitrij Feller]

Attachment: Bug 370035 - Remove the aWidget parameter from nsIDeviceContextSpec::Init.r?spohl

Comment 3

[Jonathan Watt [:jwatt]]

Dmitrij, do you need help landing this?

Comment 4

[Stephen A Pohl [:spohl]]

I meant to land this, but when I tried to do so the other day I got a warning saying that "Static analysis and linting are still in progress. [D145841] ". That warning still pops up today, so I went ahead and landed it anyway.

Comment 5

[Dmitrij Feller]

Thanks :jwatt for asking and :spohl for taking over. I don't have the rights to land myself. But as I see there is a merge conflict. I will fix that and then we should be able to land it.

Comment 6

[Jonathan Watt [:jwatt]]

Sorry, Dmitrij, it looks like my patches in bug 1770539 conflicted with yours in nsPrintJob.cpp. If you can refresh your patch again, Stephen or I will push it for you.

Comment 7

[Dmitrij Feller]

Hey Jonathan, no worries! I updated the patch again. Now it should be landable!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12c68a495c82
Remove the aWidget parameter from nsIDeviceContextSpec::Init.r=spohl

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/12c68a495c82