OpenBSD: sync with reality - they define uint32_t and bool

VERIFIED FIXED

Status

()

Core
Plug-ins
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: Martynas Venckus, Assigned: Martynas Venckus)

Tracking

({verified1.8.0.12, verified1.8.1.4})

Trunk
x86
OpenBSD
verified1.8.0.12, verified1.8.1.4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; OpenBSD i386; en-US; rv:1.8.1.1) Gecko/20070207 Firefox/2.0.0.1
Build Identifier: 

OpenBSD: sync with reality; we define uint32_t and bool
The diff is available at http://www.altroot.org/nptypes.diff

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 2

12 years ago
Created attachment 255471 [details] [diff] [review]
Fix a typo in the comment

FreeBSD, and OpenBSD defines uint32_t and bool. -> FreeBSD and OpenBSD define uint32_t and bool.

Found by viq <vicviq at gmail dot com>
Attachment #254727 - Attachment is obsolete: true
(Assignee)

Comment 3

12 years ago
Why nobody is taking care of it? We use this for ages in our ports tree.


http://www.openbsd.org/cgi-bin/cvsweb/src/include/inttypes.h?rev=1.9
http://www.openbsd.org/cgi-bin/cvsweb/src/include/stdbool.h?rev=1.3

Updated

12 years ago
Attachment #255471 - Flags: review?(jst)
(Assignee)

Comment 4

12 years ago
Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

12 years ago
Attachment #255471 - Attachment is patch: true
Attachment #255471 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 255471 [details] [diff] [review]
Fix a typo in the comment

r+sr=jst, assuming this doesn't break certain versions or what not.
Attachment #255471 - Flags: superreview+
Attachment #255471 - Flags: review?(jst)
Attachment #255471 - Flags: review+
(Assignee)

Comment 6

12 years ago
It does not. We are using it in our ports-tree for years. Commit it.
(Assignee)

Comment 7

11 years ago
I should have elaborated. It was tested on -current, 4.1, 4.0, 3.9, 3.8, 3.7, 3.6.
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Assignee: nobody → martynas
Status: ASSIGNED → NEW
Whiteboard: [checkin needed]
(Assignee)

Updated

11 years ago
Attachment #255471 - Flags: approval1.8.1.4?
Attachment #255471 - Flags: approval1.8.0.12?

Comment 8

11 years ago
Comment on attachment 255471 [details] [diff] [review]
Fix a typo in the comment

mozilla/modules/plugin/base/public/nptypes.h 	3.26
Summary: OpenBSD: sync with reality; we define uint32_t and bool → OpenBSD: sync with reality - they define uint32_t and bool
Whiteboard: [checkin needed]
(Assignee)

Comment 9

11 years ago
What about 1.8.1.4 and 1.8.0.12 and checkins?

Comment 10

11 years ago
they would have to come after approval flags. in the interim confirming the bug is fixed tends to speed (somewhat) the process.
(Assignee)

Comment 11

11 years ago
The rev. 3.26 works, marking FIXED.
The branch checkins are still needed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [1.8.1.4 and 1.8.0.12 branch commits needed]
Comment on attachment 255471 [details] [diff] [review]
Fix a typo in the comment

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #255471 - Flags: approval1.8.1.4?
Attachment #255471 - Flags: approval1.8.1.4+
Attachment #255471 - Flags: approval1.8.0.12?
Attachment #255471 - Flags: approval1.8.0.12+
(Assignee)

Updated

11 years ago
Whiteboard: [1.8.1.4 and 1.8.0.12 branch commits needed]
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.12, fixed1.8.1.4
Martynas, could you help us verify this on the branches?
(Assignee)

Comment 14

11 years ago
Verifying; it now uses our uint32_t and bool on branches.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.12, fixed1.8.1.4 → verified1.8.0.12, verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.