Closed
Bug 370084
Opened 17 years ago
Closed 17 years ago
Allow for blacklisting in the popup exceptions list
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.3, Whiteboard: l10n)
Attachments
(2 files, 3 obsolete files)
4.54 KB,
patch
|
froodian
:
review+
mark
:
superreview+
|
Details | Diff | Splinter Review |
13.37 KB,
application/octet-stream
|
alqahira
:
review+
|
Details |
Right now any popup hostperm entry is shown as if it were a whitelist. Once bug 343937 lands, there will be blacklist entries there as well, so we need the popup UI to be more like the cookie perm UI.
Flags: camino1.1b1?
Whiteboard: l10n
Assignee | ||
Comment 1•17 years ago
|
||
I won't bother to post a nib until the flashblock stuff is landed, since it would just go stale, but here's the code part. This is mostly just stolen from the cookie sheet in Privacy. I know it would be good to support sorting here, but it probably won't happen for 1.1. I filed bug 370119 to cover that and other disparities between popups and cookies.
Comment 2•17 years ago
|
||
Comment on attachment 254782 [details] [diff] [review] fix Obviously I haven't tested it, but r=me codewise.
Attachment #254782 -
Flags: superreview?
Attachment #254782 -
Flags: review?(stridey)
Attachment #254782 -
Flags: review+
Assignee | ||
Comment 3•17 years ago
|
||
+'ing for b1. Now that bug 343937 is in, the whitelist is really a blacklist/whitelist, so the UI for the exceptions list is wrong until this is fixed.
Flags: camino1.1b1? → camino1.1b1+
Assignee | ||
Comment 4•17 years ago
|
||
Built from the Flashblock nib as it will be, so it's ready for checkin.
Assignee | ||
Comment 5•17 years ago
|
||
Now with correct-tab-chain action!
Attachment #255900 -
Attachment is obsolete: true
Updated•17 years ago
|
Attachment #254782 -
Flags: superreview? → superreview+
Updated•17 years ago
|
Attachment #255904 -
Flags: review+
Assignee | ||
Comment 6•17 years ago
|
||
It just keeps getting less wrong.
Attachment #255904 -
Attachment is obsolete: true
Assignee | ||
Comment 7•17 years ago
|
||
Are we there yet?
Attachment #255941 -
Attachment is obsolete: true
Comment on attachment 255945 [details]
better yet
Yep, we're there now.
Attachment #255945 -
Flags: review+
Assignee | ||
Comment 9•17 years ago
|
||
Checked in on trunk and MOZILLA_1_8_BRANCH.
You need to log in
before you can comment on or make changes to this bug.
Description
•