370105 - Remove ViewConfigurator and "system-area" cruft

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Unify commands and DND enabled-state for "special" folders in places views.

With the complex ViewConfigurator/peerDropIndex/_selectionOverlapsSystemArea concept in place, the enabled state of DND and various commands for "special" folders selection differs between places views.

For example, the properties dialog for the bookmarks toolbar folder can be opened from the context menu for its empty area, but not from the context menu of the the toolbar folder in the left pane of the organizer.

I will also use this bug to cleanup some obsolete code in the ViewConfigurator object.

Comment 1

[Asaf Romano (gone)]

Attachment: wip

Comment 2

[O. Atsushi (Torisugari)]

(In reply to comment #1)
> Created an attachment (id=254770) [details]
> wip
> 

>-    "folder=1":
>+    "folder=1&group=3&excludeItems=1&excludeQueries=1":

Then,
"place:folder=1&FOO=1&BAR=1" and
"place:folder=1&BAR=1&FOO=1"
are different places-URIs? gh.

Comment 3

[Asaf Romano (gone)]

Thus "wip", my plan is to remove ViewConfig(urator).

Comment 4

[O. Atsushi (Torisugari)]

Aha. It sounds wonderful. Sorry for spamming.

BTW, my RFE is making it possible to create a new "special" folder by extesion
authors rather than hard scripting. 

e.g. 
When someone wants to create a "OS Native Bookmark Folder", such as IE
Favorites sync folder, then do you think the folder should be *special* as
well as the toolbar folder, on user's DND?

Comment 5

[Asaf Romano (gone)]

You should be able to use remote containers for that sort of container.

Comment 6

[Asaf Romano (gone)]

s/of container/of query.

Comment 7

[O. Atsushi (Torisugari)]

> You should be able to use remote containers for that sort of query.

I doubt it.

Comment 8

[Asaf Romano (gone)]

Well, remote containers are designed for that sort of thing afaict. It probably doesn't work right yet, file bugs? This doesn't really belong here.

Comment 9

[O. Atsushi (Torisugari)]

The point is it's special when the user is dragging an object, right? I don't
mind remote containers fail to work. Someone might happen to want to set his/her
remote container as *special*. Maybe it's not a remote container.

Comment 10

[Asaf Romano (gone)]

Attachment: remove systemarea and viewconfigurator concepts

This will introduce some regression in the left pane of the organizer, I will address those after this patch is landed.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 259355 [details] [diff] [review]
remove systemarea and viewconfigurator concepts

r=sspitzer

dietrich wrote over irc:

+// XXXmano: we should most/all of these constants to PlacesUtils

"s/should most/should move/"

asaf, since you have list of minor regressions that you know will result of this landing, can you log a spin off bug with them?

Comment 12

[(not reading, please use [e-mail] instead)]

s/dietrich wrote over irc:/asaf wrote over irc:

Comment 13

[Asaf Romano (gone)]

Filed bug 374986.

Comment 14

[Asaf Romano (gone)]

mozilla/browser/components/places/content/controller.js 1.137
mozilla/browser/components/places/content/menu.xml 1.67
mozilla/browser/components/places/content/toolbar.xml 1.77
mozilla/browser/components/places/content/tree.xml 1.58
mozilla/browser/components/places/content/utils.js 1.22

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv