Closed
Bug 370107
Opened 18 years ago
Closed 18 years ago
nsScreenManagerCocoa::ScreenForRect won't match any screen when window partly offscreen
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sylvain.pasche, Assigned: jaas)
References
Details
Attachments
(1 file, 2 obsolete files)
|
1.79 KB,
patch
|
jaas
:
review+
pavlov
:
superreview+
|
Details | Diff | Splinter Review |
Maybe use a maximum intersection area algorithm like widget/gtk2 instead of NSContainsRect (or maybe there's already something in the API for this).
|
Reporter | |
Updated•18 years ago
|
Summary: nsScreenManagerMac::ScreenForRect won't match any screen when window partly offscreen → nsScreenManagerCocoa::ScreenForRect won't match any screen when window partly offscreen
|
|
Reporter | |
Comment 1•18 years ago
|
||
Attachment #255397 -
Flags: review?(joshmoz)
Comment on attachment 255397 [details] [diff] [review]
version 1
Patch no longer applies to current trunk. Can you update it please?
Attachment #255397 -
Flags: review?(joshmoz)
|
|
Reporter | |
Comment 3•18 years ago
|
||
Attachment #255397 -
Attachment is obsolete: true
Attachment #256092 -
Flags: review?(joshmoz)
|
|
Reporter | |
Updated•18 years ago
|
Attachment #256092 -
Flags: review?(joshmoz)
|
|
Reporter | |
Comment 4•18 years ago
|
||
I killed local variable nsScreenCocoa *sc which was unused. I guess one could even do the assignment inside NS_ADDREF, but that would be against existing style.
Attachment #256092 -
Attachment is obsolete: true
Attachment #256097 -
Flags: review?(joshmoz)
Attachment #256097 -
Flags: review?(joshmoz) → review+
Attachment #256097 -
Flags: superreview?(pavlov)
|
||
Updated•18 years ago
|
Attachment #256097 -
Flags: superreview?(pavlov) → superreview+
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•