Standardize package/unpackage utilities for win32/mac/unix and make the build/supporting utilities use them

RESOLVED WONTFIX

Status

P3
normal
RESOLVED WONTFIX
12 years ago
5 years ago

People

(Reporter: coop, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

12 years ago
This is a tinderbox client bug, which means we'll end up dealing with it anyway.

The test-only tinderboxen (currently bl-bldlnx01 and bl-bldxp01) have some straightforward logic coded into build-seamonkey-util.pl for unpacking builds downloaded for testing. Unfortunately, this code doesn't deal with:
1) Windows installer builds
2) Mac disk images (.dmg)

We already crossed this bridge before with the repackaging (which is why I've cc-ed bsmedberg). We should re-use the existing unpackaging code to minimize maintenance and future-proof the testing tinderbox code as much as possible. The old repackaging scripts make use functions described in packager.mk:

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#136

This is a bit of a headache because it means that even test-only tinderboxen will need to checkout and configure some minimal install of the CVS tree in order to simply unpack incoming builds for testing. Maybe this doesn't have to happen every time a new build is downloaded...we can have a long-lived checkout on each testing box that only gets updated when we change how we package (or something breaks).

Regardless, we would need to add some UNMAKE-only targets to makefiles, and the tinderbox client would need to be adapted to call those targets.
(Reporter)

Comment 1

12 years ago
As rhelmer, this could quite easily become redundant as we move towards Buildbot for testing (<a href="http://wiki.mozilla.org/MozillaQualityAssurance:Test_Farm_Roadmap">MozillaQualityAssurance:Test_Farm_Roadmap</a>). Buildbot should still be reusing the existing re-/unpackaging code.

Comment 2

12 years ago
Rhelmer and I have talked about this on a number of occasions; is UNMAKE_PACKAGE a script?

I think what would be preferable is to have a script that packages/unpackages the binaries, and that script is then called by the build system. That way, we can use the script in other tools without having to pull out an entire CVS environment.

There was some discussion of doing this in MozBuild::Util, but we obviously didn't get very far.
(Reporter)

Comment 3

12 years ago
No, UNMAKE_PACKAGE defines a set of steps that are then called by other targets. AFAICT, there is no existing target that only does unpackaging.

I would  agree that a re-usable script would be more practical in this context, but such a thing doesn't exist yet, which is why I'm pointing at UNMAKE_PACKAGE as the only extant example.

Comment 4

12 years ago
Perfect... we've got something to use as a starting point. So, UNMAKE_PACKAGE should be ported to a script for the testing tinderboxen to use?

Is that a better summary for this bug?
(Reporter)

Updated

12 years ago
Summary: TestOnlyTinderbox should use $UNMAKE_PACKAGE for unpacking builds for testing → Use $UNMAKE_PACKAGE as the basis for an unpacking script for test-only tinderboxes

Updated

11 years ago
Priority: -- → P3
Summary: Use $UNMAKE_PACKAGE as the basis for an unpacking script for test-only tinderboxes → Standardize package/unpackage utilities for win32/mac/unix and make the build/supporting utilities use them
Assignee: build → nobody
QA Contact: mozpreed → build
Found in triage. Whats left to to here, or can we WONTFIX this?
(Reporter)

Comment 6

11 years ago
The old style performance testing boxes are being replaced by Talos. WONTFIXing.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.